Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of json files #510

Closed
rmader opened this issue Jun 2, 2016 · 1 comment
Closed

Clean up of json files #510

rmader opened this issue Jun 2, 2016 · 1 comment

Comments

@rmader
Copy link
Contributor

rmader commented Jun 2, 2016

The json-files we use for the AAA system currently never get cleaned up, making them grow forever and saving user data (like ips) in clear text.

As I need some kind of cleaup system for the DAO.authentication file anyways, I'd like to implement a cleanup function (has to be thread-save) that removes all entries with a valid_until key that holds a timestamp smaller then the current one.
It has to be triggered by a thread that wakes up maybe every ten minutes or so, triggering the cleanup for the corresponding files.

Edit: to be future save, we should use long as the timestamp format.

@rmader rmader added this to the GSOC 2016 Milestone 3 milestone Jun 2, 2016
@rmader rmader self-assigned this Jun 2, 2016
rmader referenced this issue Jun 3, 2016
had been assigned based on moderation or contracts, authentications may
expire (i.e. seession time-out)
@Orbiter Orbiter added the wontfix label Jun 5, 2016
@Orbiter
Copy link
Member

Orbiter commented Jun 5, 2016

We should not store data in the AAA files which then have to be cleaned up. This effect is circumvented with dc57121 where volatile information is never stored in the json files.

@Orbiter Orbiter closed this as completed Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants