Editor handling

[lokothodida]

CKEditor and CodeMirror are likely to undergo modularisation in the GS Core in the future. Currently both editors are handled with code copy-pasted from the core, but it may be best to do so separately instead.

It is relatively simply to have the catalog editor logic completely separate from the rest of the GS installation and only provide what is needed for the catalog itself. Perhaps have editor options in the Options panel?

[Tzvook]

Yes, editor options in the Options panel is the best option, I fixed it since my GS site has it's own editor options and it broke the wysiwyg.

[lokothodida]

What sorts of options should be available?

• GS's advanced options?
• ...

Also, it might be possible to add a small CKEditor plugin that allows the admin to more easily embed a link to an existing product/category (but I don't want to get too ahead of myself here).

[lokothodida]

Current v0.2 branch has the following:

Editor enabled

Editor disabled

Will need to add in a few more i18n hashes for the language file for this change (and likely others).

[Tzvook]

Looks good, I'll test it tomorrow ..
You saw what I wrote about the image-picker (it's in my fork, at the 0.1 - https://github.com/Tzvook/gs-catalog ) ? I added "Image" field to the custom-fields , but it probably need to be done to the category images too ..

[lokothodida]

I saw it, and will integrate the changes soon as well. Are you making any more changes to the plugin at the moment? Because it might be best to merge your changes in soon/now before my changes diverge too hugely from the current master. It's possible also that v0.2 is released as a pre-production beta before further changes are made, and that the changes are easier to document.

I've merged your changes into the master branch on the main repository, and I am going to merge v0.2 in soon. When that is done, update your master branch (as stated by the asterisk here), create a new branch for the changes you want to make, and work on that branch until you've done your changes and I'll merge them in (and the cycle continues any other time you want to make changes to the catalog plugin).

[Tzvook]

Yes, saw changes, looks great, tomorrow I'll try to make a big catalog with lots of products and play with it a bit... Try to find bugs...