Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with tower.app (was: Plugins not working) #83

Closed
aranw opened this issue Jan 17, 2013 · 14 comments
Closed

issues with tower.app (was: Plugins not working) #83

aranw opened this issue Jan 17, 2013 · 14 comments

Comments

@aranw
Copy link

aranw commented Jan 17, 2013

I added the following to my config.yml file.

--- 
tranzlate: 
  enabled: true
loltext: 
  enabled: true

And it seems the image isn't getting the translated commit message added, I don't know whether my images should be renamed as well but I only ever have the one image, tmp_snapshot.jpg

@mroth
Copy link
Member

mroth commented Jan 21, 2013

@aranw can you please add some more details? specifically:

  • what version of ruby are you running?
  • do you receive any error output upon committing?
  • if you run lolcommits --test --capture -m 'here is a test message' in the same repo, do you get the same results?

@aranw
Copy link
Author

aranw commented Jan 21, 2013

Ruby version - ruby 1.8.7 (2012-02-08 patchlevel 358) [universal-darwin12.0]
No errors on commit
I get an image popping up, but nothing saved when I type lolcommits -b

@mroth
Copy link
Member

mroth commented Jan 23, 2013

Strange...

  • The image that pops up for you on that test command, does it have the loltext properly overlaid?
  • What's the path to the git repo you are in? What directory path does lolcommits -b end up opening which is empty?
  • if you delete the config file and try without any configuration, does the same thing occur?

@aranw
Copy link
Author

aranw commented Jan 24, 2013

  • loltext properly overlaid on the test image popup
  • Repo is ~/Sites/AH/web, lolcommits is ~/.lolcommits/web/
  • Deleted the config and folder, reenabled everything and still not working

@mroth
Copy link
Member

mroth commented Jan 24, 2013

Alright, I pushed a new version of lolcommits to try to get to the bottom of this. Can you do [sudo] gem install lolcommits --pre which should install v0.4.1pre1 for you.

Once that's working, set an environment variable ala export LOLCOMMITS_DEBUG=1 for the current session.

Now, whenever you run lolcommits it should dump a TON of output... let's see if that output can help shed some light on what's going on!

@aranw
Copy link
Author

aranw commented Jan 25, 2013

Oh? This was what I was getting, I've installed open4 and about to test it again.

For Ruby 1.8.7, the open4 library must be installed or SH won't work
/Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require': no such file to load -- json (LoadError)
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/lolcommits-0.4.1pre1/lib/lolcommits/plugins/lolsrv.rb:3
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/lolcommits-0.4.1pre1/lib/lolcommits.rb:28
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/lolcommits-0.4.1pre1/bin/lolcommits:7
    from /usr/bin/lolcommits:23:in `load'
    from /usr/bin/lolcommits:23

@aranw
Copy link
Author

aranw commented Jan 25, 2013

Ok so I added open4 library and that got rid of the first line.

But the big error I still get.

/Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require': no such file to load -- json (LoadError)
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/lolcommits-0.4.1pre1/lib/lolcommits/plugins/lolsrv.rb:3
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/lolcommits-0.4.1pre1/lib/lolcommits.rb:28
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
    from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:36:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.0.0/lib/active_support/dependencies.rb:239:in `require'
    from /Users/aran/.rvm/gems/ruby-1.9.3-p327/gems/lolcommits-0.4.1pre1/bin/lolcommits:7
    from /usr/bin/lolcommits:23:in `load'
    from /usr/bin/lolcommits:23

@mroth
Copy link
Member

mroth commented Jan 25, 2013

Whoops, looks like the new plugin in 0.4.1 requires json which isn't in the bundle file yet. Can you please gem install json and see if that helps?

@aranw
Copy link
Author

aranw commented Jan 25, 2013

Ha it worked and gave me one hell of a screenshot! Thanks :) 👍

@aranw aranw closed this as completed Jan 25, 2013
mroth added a commit that referenced this issue Jan 25, 2013
@aranw
Copy link
Author

aranw commented Jan 28, 2013

I've also found that this isn't working via Tower app, at first I was using Tower but for debugging I switched to Terminal so I could get the output. When I went back to Tower I found I was having same issue, but don't in Terminal.

@aranw aranw reopened this Jan 28, 2013
@mroth
Copy link
Member

mroth commented Feb 18, 2013

@aranw if you go to the default OSX environment in rvm via rvm system and install lolcommits there, does it fix the issue in Tower.app?

@aranw
Copy link
Author

aranw commented Feb 19, 2013

Switching to rvm system has not solved the issue.

@matthutchinson
Copy link
Member

Now fixed in gem release 0.5.5! (see the CHANGELOG for more details)

gem install lolcommits to get the latest version 👍

@matthutchinson
Copy link
Member

NOTE: After installing the latest version you'll need to lolcommits --disable and then lolcommits --enable again to fix any existing hook already set from an earlier gem install.

If lolcommits --disable fails to remove the hook, try blowing away /path/to/your/repo/.git/hooks/post-commit (or editing that file manually to clean away any existing lolcommit applied hook before trying to enable again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants