Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Dice coefficient for empty result and empty reference be 1? #106

Closed
baumgach opened this issue May 24, 2022 · 1 comment · Fixed by #111
Closed

Should Dice coefficient for empty result and empty reference be 1? #106

baumgach opened this issue May 24, 2022 · 1 comment · Fixed by #111
Assignees

Comments

@baumgach
Copy link

Hi there,

This issue is in reference to the following line:

Shouldn't an empty reference and an empty result set output a Dice coefficient of 1 rather than 0? I.e. if no pixels of a class are present in the image and no mask is predicted, then the prediction is correct. Or am I missing something here?

(For the Jaccard coefficient the division by 0 detection seems to be missing altogether.)

Thanks and best wishes,
Christian

@baumgach baumgach changed the title Dice coefficient for empty result and empty reference Should Dice coefficient for empty result and empty reference be 1? May 24, 2022
@loli loli closed this as completed in #111 Sep 16, 2022
@loli
Copy link
Owner

loli commented Sep 16, 2022

Thanks for noticing!

@loli loli self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants