Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support non-hexadecimal job_id #21

Closed
wincss opened this issue Aug 16, 2019 · 5 comments
Closed

support non-hexadecimal job_id #21

wincss opened this issue Aug 16, 2019 · 5 comments

Comments

@wincss
Copy link

wincss commented Aug 16, 2019

I'm developer from f2pool.

lolMiner is not compatibility with f2pool, lolMiner will disconnect after f2pool sends a job with id not starting with hexadecimal character "GHyDNOoPVSw".

Connecting to pool...
Connected to <host>:<port> (TLS disabled)
Subscribed to stratum server
Authorized worker: <workername>
New target received: 0001ffffffffffff
Warning: stoull
Lost connection to stratum server <host>:<port> or server not reachable.

since lolMiner is a closed-source miner, I don't have any idea to fix this problem effectively.

@Lolliedieb
Copy link
Owner

Hello, can you tell me for which coin this is, then I can fix that.
One thing that you should be aware of that is if a jobid is not numeric its harder (internally in my miner) to compare it to the current running calculations on gpu, so diverging from stratum standard may end up in more stale shares send). But I am willing to look into this.

@wincss
Copy link
Author

wincss commented Aug 27, 2019

It's ycash. (I have already fix it on pool-side by using hexadecimal job_id.)
There had been same problem on BEAM pool before I fixed it on January.

Our zcash, zclassic, zencash (horizen) pools are still using non-hexadecimal job_id now, but Equihash 200,9 coins are mined by ASIC miner, so no one complains about this.

Does stratum standard has requirements about job_id? Could you give me some documents about that?

@Lolliedieb
Copy link
Owner

Well that always depends on the coin - most Equihash coins use the same Stratum basis.
For Beam the spec is here
https://github.com/BeamMW/beam/wiki/Beam-mining-protocol-API-(Stratum)
which is quite minimal (and there are no types written for the data what is quite bad) - but the reference node implement is only sending out integer values, not even hex ones.

Sometimes its a bit difficult to handle that all since the specs are often not precise.

@wincss
Copy link
Author

wincss commented Aug 27, 2019

Yes, there is no enough details about job_id in stratum protocol document.

We have run our bitcoin pool since 2013. Other coins' pools is derived from the origin bitcoin pool which using a non-hexadecimal job_id. I also found some other pool operator using UUID as job_id. (It seems that UUID is compatible with your miner since it always starts with hexadecimal characters.)

We will care about job_id when we develop other mining pools.

@Lolliedieb
Copy link
Owner

Should work in 1.0 (well ... already way earlier ^^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants