Body Score isnt right - Zepp Life

[AllanOricil]

Describe the bug
Impedance values are really close to what I see in the app but the body score computed by your code is 16 points above.

Expected Body Score Value: 49
Actual Body Score Value: 65.21

Zepp Life (former xiaomi app) says my BMI is of someone who is overweight. So this should give me a body score deduction value, but it does not happen:

Every Impedance metric is extremely close to what I see in the app, so the body score should also be close enough.

I think these values are wrong

xiaomi_mi_scale/src/body_score.py

Lines 48 to 49 in 3b5828d

	bmi_overweight = 28.0
	bmi_obese = 32.0

And I also dont understand why maxMalues is lower than minMalus here. Isn't it inverted?

xiaomi_mi_scale/src/body_score.py

Lines 74 to 75 in 3b5828d

	if self.bmi > bmi_overweight:
	return self.getMalus(self.bmi, 28.0, 25.0, 5, 10) + 5.0

My bmi deduction score returns 0 because it reaches this line

xiaomi_mi_scale/src/body_score.py

Line 77 in 3b5828d

return 0.0

but it should compute something in this one because my bmi is above 25 and below 30 (overweight)

xiaomi_mi_scale/src/body_score.py

Line 75 in 3b5828d

return self.getMalus(self.bmi, 28.0, 25.0, 5, 10) + 5.0

[lolouk44]

Thanks. I'm away at the moment, coming back at the end of the month, I'll look at it then
As a disclaimer, I did not write the body measurement logic, I took it from a library that was extracted from the Xiaomi app about 3 years ago so it's highly likely the logic has changed and improved since.

[lolouk44]

Sorry not getting much time to look into this.
Since you've already identified where the code looks wrong, have you managed to change it for your needs / to make it work?
If so feel free to submit a PR. Please note I've recently rewritten the code to use the bleak library instead of the no longer supported bluepy one.

[x11x]

Hi @AllanOricil,
Can I just ask how you are using body_score.py? It does not currently seem to be used anywhere in this repo, you have written your own code importing body_score to generate those tables?
Thanks