fix: Signing out clearing all user preferences #10
Conversation
Avoid two tabs after login Avoid two tabs after login Avoid two tabs after login
Feature: Allow customization of Success and failure screens on login
change GoogleSignInPlatform to GoogleSignInDart
|
@long1eu Hi, any updates on this? |
example/lib/main.dart
Outdated
| // All Rights Reserved. 2022. | ||
| // Unauthorized copying of this file, via any medium is strictly prohibited. | ||
| // Proprietary and confidential. | ||
| // Written by Elias Kapareliotis <helpis@tutamail.com>. |
example/lib/main.dart
Outdated
| import 'package:google_sign_in_dartio/google_sign_in_dartio.dart'; | ||
| import 'package:googleapis/gmail/v1.dart'; | ||
| import 'package:googleapis/people/v1.dart'; | ||
| import 'package:googleapis_auth/googleapis_auth.dart'; | ||
| import 'package:html_unescape/html_unescape.dart'; | ||
|
|
||
| import 'platform_js.dart' if (dart.library.io) 'platform_io.dart'; |
lib/google_sign_in_dartio.dart
Outdated
| DataStorage? storage, | ||
| UrlPresenter? presenter, | ||
| int? port, | ||
| final int? port, |
There was a problem hiding this comment.
I think that we need to have an Options class that we should pass and not keep adding new values here.
waiting for some clarifications |
|
Yes I'm sorry Android Studio config, I was just checking that. Seems that I had forgotten I had opened the pull request and while working on another private project things got pushed together, my mistake. I checked the git history and I don't see to have changed anything important after the merging other open prs. All the garbage commits are after that point. Since it's linear history up to there, theoretically a git hard reset should solve the issue. I'm currently working on it. Sorry for the inconvenience this happened due to my negligence. |
|
Again, I'm really sorry for the trouble, I feel kinda ashamed I didn't notice that earlier. Git reset hard and git push -f restored it to clear point and removed all the unnecessary garbage commits. |
|
Absolutely no problem. Thank you for your interest. |
|
Please recreate and let me know. |
Fixes a bug (unintended behavior) where performing a 'sign out with google' action, clears all user's shared preferences, even values not used by the plugin. Fixed it by just setting to null the values the plugin actually uses, since it already had a
clearmethod that almost did exactly that, except for the user ID.