Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm package wrong main file #438

Closed
aaronkzhou opened this issue May 22, 2018 · 4 comments
Closed

Npm package wrong main file #438

aaronkzhou opened this issue May 22, 2018 · 4 comments

Comments

@aaronkzhou
Copy link

https://www.npmjs.com/package/jquery-date-range-picker

the main file should change from require('./src/jquery.daterangepicker.js') to require('./dist/jquery.daterangepicker.js');;

@holtkamp
Copy link
Collaborator

So what should it be?

require('./src/jquery.daterangepicker.js')

or

require('./dist/jquery.daterangepicker.js')

? Any documentation available on where to look this up?

@aaronkzhou
Copy link
Author

aaronkzhou commented Jul 20, 2018

it should require('./dist/jquery.daterangepicker.js');, it doesn't work for requiring require('./src/jquery.daterangepicker.js'), don't know why, just change the package.json main pls

@holtkamp
Copy link
Collaborator

Well, I do not have access to https://www.npmjs.com/package/jquery-date-range-picker, it seems https://www.npmjs.com/~youpinyao created it. @youpinyao?. The version there (1.0.4) also does not match "our" versions: https://github.com/longbill/jquery-date-range-picker/tags

So I am afraid I can not help...

@holtkamp
Copy link
Collaborator

This is probably resolved in https://github.com/longbill/jquery-date-range-picker/releases/tag/v0.19.0

Note we went for the 'src' approach. You should build it yourself, also see #441 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants