/
validator.go
208 lines (177 loc) · 7.15 KB
/
validator.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
package node
import (
"fmt"
"math"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"k8s.io/apimachinery/pkg/runtime"
admissionregv1 "k8s.io/api/admissionregistration/v1"
"github.com/longhorn/longhorn-manager/datastore"
"github.com/longhorn/longhorn-manager/types"
"github.com/longhorn/longhorn-manager/util"
"github.com/longhorn/longhorn-manager/webhook/admission"
longhorn "github.com/longhorn/longhorn-manager/k8s/pkg/apis/longhorn/v1beta2"
werror "github.com/longhorn/longhorn-manager/webhook/error"
)
type nodeValidator struct {
admission.DefaultValidator
ds *datastore.DataStore
}
func NewValidator(ds *datastore.DataStore) admission.Validator {
return &nodeValidator{ds: ds}
}
func (n *nodeValidator) Resource() admission.Resource {
return admission.Resource{
Name: "nodes",
Scope: admissionregv1.NamespacedScope,
APIGroup: longhorn.SchemeGroupVersion.Group,
APIVersion: longhorn.SchemeGroupVersion.Version,
ObjectType: &longhorn.Node{},
OperationTypes: []admissionregv1.OperationType{
admissionregv1.Create,
admissionregv1.Update,
},
}
}
func (n *nodeValidator) Create(request *admission.Request, newObj runtime.Object) error {
node, ok := newObj.(*longhorn.Node)
if !ok {
return werror.NewInvalidError(fmt.Sprintf("%v is not a *longhorn.Node", newObj), "")
}
if node.Spec.InstanceManagerCPURequest < 0 {
return werror.NewInvalidError("instanceManagerCPURequest should be greater than or equal to 0", "")
}
v2DataEngineEnabled, err := n.ds.GetSettingAsBool(types.SettingNameV2DataEngine)
if err != nil {
err = errors.Wrapf(err, "failed to get spdk setting")
return werror.NewInvalidError(err.Error(), "")
}
for name, disk := range node.Spec.Disks {
if !v2DataEngineEnabled {
if disk.Type == longhorn.DiskTypeBlock {
return werror.NewInvalidError(fmt.Sprintf("disk %v type %v is not supported since v2 data engine is disabled", name, disk.Type), "")
}
}
if disk.Type == longhorn.DiskTypeBlock {
if disk.StorageReserved != 0 {
return werror.NewInvalidError(fmt.Sprintf("disk %v type %v is not supported to reserve storage", name, disk.Type), "")
}
}
}
return nil
}
func (n *nodeValidator) Update(request *admission.Request, oldObj runtime.Object, newObj runtime.Object) error {
oldNode, ok := oldObj.(*longhorn.Node)
if !ok {
return werror.NewInvalidError(fmt.Sprintf("%v is not a *longhorn.Node", oldObj), "")
}
newNode, ok := newObj.(*longhorn.Node)
if !ok {
return werror.NewInvalidError(fmt.Sprintf("%v is not a *longhorn.Node", newObj), "")
}
if newNode.Spec.InstanceManagerCPURequest < 0 {
return werror.NewInvalidError("instanceManagerCPURequest should be greater than or equal to 0", "")
}
// Only scheduling disabled node can be evicted
// Can not enable scheduling on an evicting node
if newNode.Spec.EvictionRequested && newNode.Spec.AllowScheduling {
return werror.NewInvalidError(fmt.Sprintf("need to disable scheduling on node %v for node eviction, or cancel eviction to enable scheduling on this node",
oldNode.Name), "")
}
// Ensure the node controller already syncs the disk spec and status.
if !isNodeDiskSpecAndStatusSynced(oldNode) {
return werror.NewForbiddenError(fmt.Sprintf("spec and status of disks on node %v are being syncing and please retry later.", oldNode.Name))
}
// We need to make sure the tags passed in are valid before updating the node.
_, err := util.ValidateTags(newNode.Spec.Tags)
if err != nil {
return werror.NewInvalidError(err.Error(), "")
}
if newNode.Spec.InstanceManagerCPURequest != 0 {
kubeNode, err := n.ds.GetKubernetesNodeRO(oldNode.Name)
if err != nil {
if !datastore.ErrorIsNotFound(err) {
return werror.NewInvalidError(err.Error(), "")
}
logrus.Warnf("Kubernetes node %v has been deleted", oldNode.Name)
}
if err == nil {
allocatableCPU := float64(kubeNode.Status.Allocatable.Cpu().MilliValue())
instanceManagerCPUSetting, err := n.ds.GetSettingWithAutoFillingRO(types.SettingNameGuaranteedInstanceManagerCPU)
if err != nil {
return werror.NewInvalidError(err.Error(), "")
}
instanceManagerCPUInPercentage := instanceManagerCPUSetting.Value
if newNode.Spec.InstanceManagerCPURequest > 0 {
instanceManagerCPUInPercentage = fmt.Sprintf("%.0f", math.Round(float64(newNode.Spec.InstanceManagerCPURequest)/allocatableCPU*100.0))
}
if err := types.ValidateCPUReservationValues(instanceManagerCPUInPercentage); err != nil {
return werror.NewInvalidError(err.Error(), "")
}
}
}
// Only scheduling disabled disk can be evicted
// Can not enable scheduling on an evicting disk
for diskName, diskSpec := range newNode.Spec.Disks {
if diskSpec.EvictionRequested && diskSpec.AllowScheduling {
return werror.NewInvalidError(fmt.Sprintf("need to disable scheduling on disk %v for disk eviction, or cancel eviction to enable scheduling on this disk",
diskName), "")
}
}
v2DataEngineEnabled, err := n.ds.GetSettingAsBool(types.SettingNameV2DataEngine)
if err != nil {
err = errors.Wrapf(err, "failed to get spdk setting")
return werror.NewInvalidError(err.Error(), "")
}
// Validate Disks StorageReserved, Tags and Type
for name, disk := range newNode.Spec.Disks {
if disk.StorageReserved < 0 {
return werror.NewInvalidError(fmt.Sprintf("update disk on node %v error: The storageReserved setting of disk %v(%v) is not valid, should be positive and no more than storageMaximum and storageAvailable",
newNode.Name, name, disk.Path), "")
}
_, err := util.ValidateTags(disk.Tags)
if err != nil {
return werror.NewInvalidError(err.Error(), "")
}
if !v2DataEngineEnabled {
if disk.Type == longhorn.DiskTypeBlock {
return werror.NewInvalidError(fmt.Sprintf("update disk on node %v error: The disk %v(%v) is a block device, but the SPDK feature is not enabled",
newNode.Name, name, disk.Path), "")
}
}
if disk.Type == longhorn.DiskTypeBlock {
if disk.StorageReserved != 0 {
return werror.NewInvalidError(fmt.Sprintf("disk %v type %v is not supported to reserve storage", name, disk.Type), "")
}
}
}
// Validate delete disks
for name, disk := range oldNode.Spec.Disks {
if _, ok := newNode.Spec.Disks[name]; !ok {
if disk.AllowScheduling || oldNode.Status.DiskStatus[name].StorageScheduled != 0 {
logrus.Infof("Delete Disk on node %v error: Please disable the disk %v and remove all replicas first ", name, disk.Path)
return werror.NewInvalidError(fmt.Sprintf("Delete Disk on node %v error: Please disable the disk %v and remove all replicas first ", name, disk.Path), "")
}
}
}
// Validate disk type change, the disk type is not allow to change
for name, disk := range oldNode.Spec.Disks {
if newDisk, ok := newNode.Spec.Disks[name]; ok {
if disk.Type != "" && disk.Type != newDisk.Type {
return werror.NewInvalidError(fmt.Sprintf("update disk on node %v error: The disk %v(%v) type is not allow to change", newNode.Name, name, disk.Path), "")
}
}
}
return nil
}
func isNodeDiskSpecAndStatusSynced(node *longhorn.Node) bool {
if len(node.Spec.Disks) != len(node.Status.DiskStatus) {
return false
}
for diskName := range node.Spec.Disks {
if _, ok := node.Status.DiskStatus[diskName]; !ok {
return false
}
}
return true
}