-
Notifications
You must be signed in to change notification settings - Fork 140
/
engine_controller.go
2193 lines (1892 loc) · 74.7 KB
/
engine_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package controller
import (
"context"
"fmt"
"reflect"
"regexp"
"strconv"
"strings"
"sync"
"time"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
"k8s.io/client-go/util/flowcontrol"
"k8s.io/kubernetes/pkg/controller"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
clientset "k8s.io/client-go/kubernetes"
v1core "k8s.io/client-go/kubernetes/typed/core/v1"
lhexec "github.com/longhorn/go-common-libs/exec"
lhtypes "github.com/longhorn/go-common-libs/types"
etypes "github.com/longhorn/longhorn-engine/pkg/types"
imapi "github.com/longhorn/longhorn-instance-manager/pkg/api"
imclient "github.com/longhorn/longhorn-instance-manager/pkg/client"
imutil "github.com/longhorn/longhorn-instance-manager/pkg/util"
"github.com/longhorn/longhorn-manager/constant"
"github.com/longhorn/longhorn-manager/datastore"
"github.com/longhorn/longhorn-manager/engineapi"
"github.com/longhorn/longhorn-manager/types"
"github.com/longhorn/longhorn-manager/util"
longhorn "github.com/longhorn/longhorn-manager/k8s/pkg/apis/longhorn/v1beta2"
)
const (
unknownReplicaPrefix = "UNKNOWN-"
restoreGetLockFailedPatternMsg = "error initiating (full|incremental) backup restore: failed lock"
restoreAlreadyInProgressMsg = "already in progress"
restoreAlreadyRestoredBackupMsg = "already restored backup"
)
var (
EnginePollInterval = 5 * time.Second
EnginePollTimeout = 30 * time.Second
EngineMonitorConflictRetryCount = 5
purgeWaitIntervalInSecond = 24 * 60 * 60
// restoreMaxInterval: deleting the backup of big size volume takes a long time for retain policy and restoring backups would be in backoff period.
restoreMaxInterval = 1 * time.Hour
)
const (
ConflictRetryCount = 5
)
type EngineController struct {
*baseController
// which namespace controller is running with
namespace string
// use as the OwnerID of the controller
controllerID string
kubeClient clientset.Interface
eventRecorder record.EventRecorder
ds *datastore.DataStore
cacheSyncs []cache.InformerSynced
backoff *flowcontrol.Backoff
instanceHandler *InstanceHandler
engines engineapi.EngineClientCollection
engineMonitorMutex *sync.RWMutex
engineMonitorMap map[string]chan struct{}
proxyConnCounter util.Counter
restoringCounter util.Counter
restoringCounterMutex *sync.Mutex
}
type EngineMonitor struct {
logger logrus.FieldLogger
namespace string
ds *datastore.DataStore
eventRecorder record.EventRecorder
Name string
engines engineapi.EngineClientCollection
stopCh chan struct{}
expansionBackoff *flowcontrol.Backoff
restoreBackoff *flowcontrol.Backoff
expansionUpdateTime time.Time
controllerID string
// used to notify the controller that monitoring has stopped
monitorVoluntaryStopCh chan struct{}
proxyConnCounter util.Counter
restoringCounter util.Counter
restoringCounterAcquired bool
restoringCounterMutex *sync.Mutex
}
func NewEngineController(
logger logrus.FieldLogger,
ds *datastore.DataStore,
scheme *runtime.Scheme,
kubeClient clientset.Interface,
engines engineapi.EngineClientCollection,
namespace string, controllerID string,
proxyConnCounter util.Counter) *EngineController {
eventBroadcaster := record.NewBroadcaster()
eventBroadcaster.StartLogging(logrus.Infof)
// TODO: remove the wrapper when every clients have moved to use the clientset.
eventBroadcaster.StartRecordingToSink(&v1core.EventSinkImpl{Interface: v1core.New(kubeClient.CoreV1().RESTClient()).Events("")})
ec := &EngineController{
baseController: newBaseController("longhorn-engine", logger),
ds: ds,
namespace: namespace,
controllerID: controllerID,
kubeClient: kubeClient,
eventRecorder: eventBroadcaster.NewRecorder(scheme, corev1.EventSource{Component: "longhorn-engine-controller"}),
backoff: flowcontrol.NewBackOff(time.Second*10, time.Minute*5),
engines: engines,
engineMonitorMutex: &sync.RWMutex{},
engineMonitorMap: map[string]chan struct{}{},
proxyConnCounter: proxyConnCounter,
restoringCounter: util.NewAtomicCounter(),
restoringCounterMutex: &sync.Mutex{},
}
ec.instanceHandler = NewInstanceHandler(ds, ec, ec.eventRecorder)
ds.EngineInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: ec.enqueueEngine,
UpdateFunc: func(old, cur interface{}) { ec.enqueueEngine(cur) },
DeleteFunc: ec.enqueueEngine,
})
ec.cacheSyncs = append(ec.cacheSyncs, ds.EngineInformer.HasSynced)
ds.InstanceManagerInformer.AddEventHandlerWithResyncPeriod(cache.ResourceEventHandlerFuncs{
AddFunc: ec.enqueueInstanceManagerChange,
UpdateFunc: func(old, cur interface{}) { ec.enqueueInstanceManagerChange(cur) },
DeleteFunc: ec.enqueueInstanceManagerChange,
}, 0)
ec.cacheSyncs = append(ec.cacheSyncs, ds.InstanceManagerInformer.HasSynced)
return ec
}
func (ec *EngineController) Run(workers int, stopCh <-chan struct{}) {
defer utilruntime.HandleCrash()
defer ec.queue.ShutDown()
ec.logger.Info("Starting Longhorn engine controller")
defer ec.logger.Info("Shut down Longhorn engine controller")
if !cache.WaitForNamedCacheSync("longhorn engines", stopCh, ec.cacheSyncs...) {
return
}
for i := 0; i < workers; i++ {
go wait.Until(ec.worker, time.Second, stopCh)
}
<-stopCh
}
func (ec *EngineController) worker() {
for ec.processNextWorkItem() {
}
}
func (ec *EngineController) processNextWorkItem() bool {
key, quit := ec.queue.Get()
if quit {
return false
}
defer ec.queue.Done(key)
err := ec.syncEngine(key.(string))
ec.handleErr(err, key)
return true
}
func (ec *EngineController) handleErr(err error, key interface{}) {
if err == nil {
ec.queue.Forget(key)
return
}
log := ec.logger.WithField("engine", key)
if ec.queue.NumRequeues(key) < maxRetries {
handleReconcileErrorLogging(log, err, "Failed to sync Longhorn engine")
ec.queue.AddRateLimited(key)
return
}
utilruntime.HandleError(err)
handleReconcileErrorLogging(log, err, "Dropping Longhorn engine out of the queue")
ec.queue.Forget(key)
}
func getLoggerForEngine(logger logrus.FieldLogger, e *longhorn.Engine) *logrus.Entry {
return logger.WithField("engine", e.Name)
}
func (ec *EngineController) getEngineClientProxy(e *longhorn.Engine, image string) (engineapi.EngineClientProxy, error) {
engineCliClient, err := GetBinaryClientForEngine(e, ec.engines, image)
if err != nil {
return nil, err
}
return engineapi.GetCompatibleClient(e, engineCliClient, ec.ds, ec.logger, ec.proxyConnCounter)
}
func (ec *EngineController) syncEngine(key string) (err error) {
defer func() {
err = errors.Wrapf(err, "failed to sync engine for %v", key)
}()
namespace, name, err := cache.SplitMetaNamespaceKey(key)
if err != nil {
return err
}
if namespace != ec.namespace {
// Not ours, don't do anything
return nil
}
log := ec.logger.WithField("engine", name)
engine, err := ec.ds.GetEngine(name)
if err != nil {
if datastore.ErrorIsNotFound(err) {
return nil
}
return errors.Wrapf(err, "failed to get engine")
}
defaultEngineImage, err := ec.ds.GetSettingValueExisted(types.SettingNameDefaultEngineImage)
if err != nil {
return err
}
isResponsible, err := ec.isResponsibleFor(engine, defaultEngineImage)
if err != nil {
return err
}
if !isResponsible {
return nil
}
if engine.Status.OwnerID != ec.controllerID {
engine.Status.OwnerID = ec.controllerID
engine, err = ec.ds.UpdateEngineStatus(engine)
if err != nil {
// we don't mind others coming first
if apierrors.IsConflict(errors.Cause(err)) {
return nil
}
return err
}
log.Infof("Engine got new owner %v", ec.controllerID)
}
if engine.DeletionTimestamp != nil {
if err := ec.DeleteInstance(engine); err != nil {
return errors.Wrapf(err, "failed to clean up the related engine instance before deleting engine %v", engine.Name)
}
return ec.ds.RemoveFinalizerForEngine(engine)
}
existingEngine := engine.DeepCopy()
defer func() {
// we're going to update engine assume things changes
if err == nil && !reflect.DeepEqual(existingEngine.Status, engine.Status) {
_, err = ec.ds.UpdateEngineStatus(engine)
}
// requeue if it's conflict
if apierrors.IsConflict(errors.Cause(err)) {
log.WithError(err).Debug("Requeue engine due to conflict")
ec.enqueueEngine(engine)
err = nil
}
}()
isCLIAPIVersionOne := false
if datastore.IsDataEngineV1(engine.Spec.DataEngine) {
if engine.Status.CurrentImage != "" {
isCLIAPIVersionOne, err = ec.ds.IsEngineImageCLIAPIVersionOne(engine.Status.CurrentImage)
if err != nil {
return err
}
}
}
syncReplicaAddressMap := false
if len(engine.Spec.UpgradedReplicaAddressMap) != 0 && engine.Status.CurrentImage != engine.Spec.Image {
if err := ec.Upgrade(engine, log); err != nil {
// Engine live upgrade failure shouldn't block the following engine state update.
log.WithError(err).Error("Failed to run engine live upgrade")
// Sync replica address map as usual when the upgrade fails.
syncReplicaAddressMap = true
}
} else if len(engine.Spec.UpgradedReplicaAddressMap) == 0 {
syncReplicaAddressMap = true
}
if syncReplicaAddressMap && !reflect.DeepEqual(engine.Status.CurrentReplicaAddressMap, engine.Spec.ReplicaAddressMap) {
log.Infof("Updating engine current replica address map to %+v", engine.Spec.ReplicaAddressMap)
engine.Status.CurrentReplicaAddressMap = engine.Spec.ReplicaAddressMap
// Make sure the CurrentReplicaAddressMap persist in the etcd before continue
return nil
}
if err := ec.instanceHandler.ReconcileInstanceState(engine, &engine.Spec.InstanceSpec, &engine.Status.InstanceStatus); err != nil {
return err
}
// For incompatible engine, skip starting engine monitor and clean up fields when the engine is not running
if isCLIAPIVersionOne {
if engine.Status.CurrentState != longhorn.InstanceStateRunning {
engine.Status.Endpoint = ""
engine.Status.ReplicaModeMap = nil
}
return nil
}
if engine.Status.CurrentState == longhorn.InstanceStateRunning {
// we allow across monitoring temporarily due to migration case
if !ec.isMonitoring(engine) {
ec.startMonitoring(engine)
} else if engine.Status.ReplicaModeMap != nil && engine.Spec.DesireState != longhorn.InstanceStateStopped {
// If engine.Spec.DesireState == longhorn.InstanceStateStopped, we have likely already issued a command to
// shut down the engine. It is potentially dangerous to attempt to communicate with it now, as a new engine
// may start using its address.
if err := ec.ReconcileEngineState(engine); err != nil {
return err
}
}
} else if ec.isMonitoring(engine) {
// engine is not running
ec.resetAndStopMonitoring(engine)
}
if err := ec.syncSnapshotCRs(engine); err != nil {
return errors.Wrapf(err, "failed to sync with snapshot CRs for engine %v", engine.Name)
}
return nil
}
func (ec *EngineController) enqueueEngine(obj interface{}) {
key, err := controller.KeyFunc(obj)
if err != nil {
utilruntime.HandleError(fmt.Errorf("couldn't get key for object %#v: %v", obj, err))
return
}
ec.queue.Add(key)
}
func (ec *EngineController) enqueueInstanceManagerChange(obj interface{}) {
im, isInstanceManager := obj.(*longhorn.InstanceManager)
if !isInstanceManager {
deletedState, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok {
utilruntime.HandleError(fmt.Errorf("received unexpected obj: %#v", obj))
return
}
// use the last known state, to enqueue, dependent objects
im, ok = deletedState.Obj.(*longhorn.InstanceManager)
if !ok {
utilruntime.HandleError(fmt.Errorf("cannot convert DeletedFinalStateUnknown to InstanceManager object: %#v", deletedState.Obj))
return
}
}
imType, err := datastore.CheckInstanceManagerType(im)
if err != nil || (imType != longhorn.InstanceManagerTypeEngine && imType != longhorn.InstanceManagerTypeAllInOne) {
return
}
engineMap := map[string]*longhorn.Engine{}
es, err := ec.ds.ListEnginesRO()
if err != nil {
ec.logger.WithError(err).Warn("Failed to list engines")
}
for _, e := range es {
// when attaching, instance manager name is not available
// when detaching, node ID is not available
if e.Spec.NodeID == im.Spec.NodeID || e.Status.InstanceManagerName == im.Name {
engineMap[e.Name] = e
}
}
for _, e := range engineMap {
ec.enqueueEngine(e)
}
}
func (ec *EngineController) CreateInstance(obj interface{}) (*longhorn.InstanceProcess, error) {
e, ok := obj.(*longhorn.Engine)
if !ok {
return nil, fmt.Errorf("invalid object for engine process creation: %v", obj)
}
if e.Spec.VolumeName == "" || e.Spec.NodeID == "" {
return nil, fmt.Errorf("missing parameters for engine instance creation: %v", e)
}
frontend := e.Spec.Frontend
if e.Spec.DisableFrontend {
frontend = longhorn.VolumeFrontendEmpty
}
im, err := ec.ds.GetInstanceManagerByInstanceRO(obj)
if err != nil {
return nil, err
}
c, err := engineapi.NewInstanceManagerClient(im)
if err != nil {
return nil, err
}
defer c.Close()
engineReplicaTimeout, err := ec.ds.GetSettingAsInt(types.SettingNameEngineReplicaTimeout)
if err != nil {
return nil, err
}
fileSyncHTTPClientTimeout, err := ec.ds.GetSettingAsInt(types.SettingNameReplicaFileSyncHTTPClientTimeout)
if err != nil {
return nil, err
}
v, err := ec.ds.GetVolume(e.Spec.VolumeName)
if err != nil {
return nil, err
}
cliAPIVersion, err := ec.ds.GetDataEngineImageCLIAPIVersion(e.Spec.Image, e.Spec.DataEngine)
if err != nil {
return nil, err
}
return c.EngineInstanceCreate(&engineapi.EngineInstanceCreateRequest{
Engine: e,
VolumeFrontend: frontend,
EngineReplicaTimeout: engineReplicaTimeout,
ReplicaFileSyncHTTPClientTimeout: fileSyncHTTPClientTimeout,
DataLocality: v.Spec.DataLocality,
ImIP: im.Status.IP,
EngineCLIAPIVersion: cliAPIVersion,
})
}
func (ec *EngineController) DeleteInstance(obj interface{}) (err error) {
e, ok := obj.(*longhorn.Engine)
if !ok {
return fmt.Errorf("invalid object for engine process deletion: %v", obj)
}
log := getLoggerForEngine(ec.logger, e)
if datastore.IsDataEngineV1(e.Spec.DataEngine) {
err = ec.deleteInstanceWithCLIAPIVersionOne(e)
if err != nil {
return err
}
}
var im *longhorn.InstanceManager
// Not assigned or not updated, try best to delete
if e.Status.InstanceManagerName == "" {
if e.Spec.NodeID == "" {
log.Warn("Engine does not set instance manager name and node ID, will skip the actual instance deletion")
return nil
}
im, err = ec.ds.GetInstanceManagerByInstance(obj)
if err != nil {
log.WithError(err).Warn("Failed to detect instance manager for engine, will skip the actual instance deletion")
return nil
}
log.Infof("Cleaning up the process for engine in instance manager %v", im.Name)
} else {
im, err = ec.ds.GetInstanceManager(e.Status.InstanceManagerName)
if err != nil {
if !apierrors.IsNotFound(err) {
return err
}
// The related node may be directly deleted.
log.Warnf("The engine instance manager %v is gone during the engine instance %v deletion. Will do nothing for the deletion", e.Status.InstanceManagerName, e.Name)
return nil
}
}
v, err := ec.ds.GetVolumeRO(e.Spec.VolumeName)
if err != nil {
if !apierrors.IsNotFound(err) {
return err
}
}
isRWXVolume := false
if v != nil && v.Spec.AccessMode == longhorn.AccessModeReadWriteMany && !v.Spec.Migratable {
isRWXVolume = true
}
// For a RWX volume, the node down, for example, caused by kubelet restart, leads to share-manager pod deletion/recreation
// and volume detachment/attachment.
// Then, the newly created share-manager pod blindly mounts the longhorn volume inside /dev/longhorn/<pvc-name> and exports it.
// To avoid mounting a dead and orphaned volume, try to clean up the engine instance as well as the orphaned iscsi device
// regardless of the instance-manager status.
if !isRWXVolume {
if im.Status.CurrentState != longhorn.InstanceManagerStateRunning {
log.Infof("Skipping deleting engine %v since instance manager is in %v state", e.Name, im.Status.CurrentState)
return nil
}
}
log.Info("Deleting engine instance")
defer func() {
if err != nil {
log.WithError(err).Warnf("Failed to delete engine %v", e.Name)
}
if isRWXVolume && im.Status.CurrentState != longhorn.InstanceManagerStateRunning {
// Try the best to delete engine instance.
// To prevent that the volume is stuck at detaching state, ignore the error when volume is
// a RWX volume and the instance manager is not running.
//
// If the engine instance of a RWX volume is not deleted successfully:
// If a RWX volume is on node A and the network of this node is partitioned,
// the owner of the share manager (SM) is transferred to node B. The engine instance and
// the block device (/dev/longhorn/pvc-xxx) on the node A become orphaned.
// If the network of the node A gets back to normal, the SM can be shifted back to node A.
// After shifting to node A, the first reattachment fail due to the IO error resulting from the
// orphaned engine instance and block device. Then, the detachment will trigger the teardown of the
// problematic engine instance and block device. The next reattachment then will succeed.
log.Warnf("Ignored the failure of deleting engine %v", e.Name)
err = nil
}
}()
// For the engine instance in instance manager v0.7.0, we need to use the cmdline to delete the instance
// and stop the iscsi
if im.Status.APIVersion == engineapi.IncompatibleInstanceManagerAPIVersion {
url := imutil.GetURL(im.Status.IP, engineapi.InstanceManagerProcessManagerServiceDefaultPort)
args := []string{"--url", url, "engine", "delete", "--name", e.Name}
execute := lhexec.NewExecutor().Execute
deprecatedIMBinary := engineapi.GetDeprecatedInstanceManagerBinary(e.Status.CurrentImage)
_, err = execute([]string{}, deprecatedIMBinary, args, lhtypes.ExecuteNoTimeout)
if err != nil && !types.ErrorIsNotFound(err) {
return err
}
// Directly remove the instance from the map. Best effort.
delete(im.Status.Instances, e.Name)
if _, err := ec.ds.UpdateInstanceManagerStatus(im); err != nil {
return err
}
return nil
}
c, err := engineapi.NewInstanceManagerClient(im)
if err != nil {
return err
}
defer c.Close()
err = c.InstanceDelete(e.Spec.DataEngine, e.Name, string(longhorn.InstanceManagerTypeEngine), "", true)
if err != nil && !types.ErrorIsNotFound(err) {
return err
}
return nil
}
func (ec *EngineController) deleteInstanceWithCLIAPIVersionOne(e *longhorn.Engine) (err error) {
isCLIAPIVersionOne := false
if e.Status.CurrentImage != "" {
isCLIAPIVersionOne, err = ec.ds.IsEngineImageCLIAPIVersionOne(e.Status.CurrentImage)
if err != nil {
return err
}
}
if isCLIAPIVersionOne {
pod, err := ec.kubeClient.CoreV1().Pods(ec.namespace).Get(context.TODO(), e.Name, metav1.GetOptions{})
if err != nil && !apierrors.IsNotFound(err) {
return errors.Wrapf(err, "failed to get pod for old engine %v", e.Name)
}
if apierrors.IsNotFound(err) {
pod = nil
}
ec.logger.WithField("engine", e.Name).Info("Deleting engine pod because of outdated version")
ec.deleteOldEnginePod(pod, e)
}
return nil
}
func (ec *EngineController) deleteOldEnginePod(pod *corev1.Pod, e *longhorn.Engine) {
// pod already stopped
if pod == nil {
return
}
log := ec.logger.WithField("pod", pod.Name)
if pod.DeletionTimestamp != nil {
if pod.DeletionGracePeriodSeconds != nil && *pod.DeletionGracePeriodSeconds != 0 {
// force deletion in the case of node lost
deletionDeadline := pod.DeletionTimestamp.Add(time.Duration(*pod.DeletionGracePeriodSeconds) * time.Second)
now := time.Now().UTC()
if now.After(deletionDeadline) {
log.Warnf("Engine pod still exists after grace period %v passed, force deletion: now %v, deadline %v", pod.DeletionGracePeriodSeconds, now, deletionDeadline)
gracePeriod := int64(0)
if err := ec.kubeClient.CoreV1().Pods(ec.namespace).Delete(context.TODO(), pod.Name, metav1.DeleteOptions{GracePeriodSeconds: &gracePeriod}); err != nil {
log.WithError(err).Warn("Failed to force delete engine pod")
return
}
}
}
return
}
if err := ec.kubeClient.CoreV1().Pods(ec.namespace).Delete(context.TODO(), pod.Name, metav1.DeleteOptions{}); err != nil {
ec.eventRecorder.Eventf(e, corev1.EventTypeWarning, constant.EventReasonFailedStopping, "Error stopping pod for old engine %v: %v", pod.Name, err)
return
}
ec.eventRecorder.Eventf(e, corev1.EventTypeNormal, constant.EventReasonStop, "Stops pod for old engine %v", pod.Name)
}
func (ec *EngineController) GetInstance(obj interface{}) (*longhorn.InstanceProcess, error) {
e, ok := obj.(*longhorn.Engine)
if !ok {
return nil, fmt.Errorf("invalid object for engine instance get: %v", obj)
}
var (
im *longhorn.InstanceManager
err error
)
if e.Status.InstanceManagerName == "" {
im, err = ec.ds.GetInstanceManagerByInstanceRO(obj)
if err != nil {
return nil, err
}
} else {
im, err = ec.ds.GetInstanceManagerRO(e.Status.InstanceManagerName)
if err != nil {
return nil, err
}
}
c, err := engineapi.NewInstanceManagerClient(im)
if err != nil {
return nil, err
}
defer c.Close()
return c.InstanceGet(e.Spec.DataEngine, e.Name, string(longhorn.InstanceManagerTypeEngine))
}
func (ec *EngineController) LogInstance(ctx context.Context, obj interface{}) (*engineapi.InstanceManagerClient, *imapi.LogStream, error) {
e, ok := obj.(*longhorn.Engine)
if !ok {
return nil, nil, fmt.Errorf("invalid object for engine instance log: %v", obj)
}
im, err := ec.ds.GetInstanceManagerRO(e.Status.InstanceManagerName)
if err != nil {
return nil, nil, err
}
c, err := engineapi.NewInstanceManagerClient(im)
if err != nil {
return nil, nil, err
}
// TODO: #2441 refactor this when we do the resource monitoring refactor
stream, err := c.InstanceLog(ctx, e.Spec.DataEngine, e.Name, string(longhorn.InstanceManagerTypeEngine))
return c, stream, err
}
func (ec *EngineController) isMonitoring(e *longhorn.Engine) bool {
ec.engineMonitorMutex.RLock()
defer ec.engineMonitorMutex.RUnlock()
_, ok := ec.engineMonitorMap[e.Name]
return ok
}
func (ec *EngineController) startMonitoring(e *longhorn.Engine) {
stopCh := make(chan struct{})
monitorVoluntaryStopCh := make(chan struct{})
monitor := &EngineMonitor{
logger: ec.logger.WithField("engine", e.Name),
Name: e.Name,
namespace: e.Namespace,
ds: ec.ds,
eventRecorder: ec.eventRecorder,
engines: ec.engines,
stopCh: stopCh,
monitorVoluntaryStopCh: monitorVoluntaryStopCh,
expansionBackoff: flowcontrol.NewBackOff(time.Second*10, time.Minute*5),
restoreBackoff: flowcontrol.NewBackOff(time.Second*10, restoreMaxInterval),
controllerID: ec.controllerID,
proxyConnCounter: ec.proxyConnCounter,
restoringCounter: ec.restoringCounter,
restoringCounterMutex: ec.restoringCounterMutex,
}
ec.engineMonitorMutex.Lock()
defer ec.engineMonitorMutex.Unlock()
if _, ok := ec.engineMonitorMap[e.Name]; ok {
return
}
ec.engineMonitorMap[e.Name] = stopCh
go monitor.Run()
go func() {
<-monitorVoluntaryStopCh
ec.engineMonitorMutex.Lock()
delete(ec.engineMonitorMap, e.Name)
ec.engineMonitorMutex.Unlock()
}()
}
func (ec *EngineController) resetAndStopMonitoring(e *longhorn.Engine) {
if _, err := ec.ds.ResetMonitoringEngineStatus(e); err != nil {
utilruntime.HandleError(errors.Wrapf(err, "failed to update engine %v to stop monitoring", e.Name))
// better luck next time
return
}
ec.stopMonitoring(e.Name)
}
func (ec *EngineController) stopMonitoring(engineName string) {
ec.engineMonitorMutex.Lock()
defer ec.engineMonitorMutex.Unlock()
stopCh, ok := ec.engineMonitorMap[engineName]
if !ok {
return
}
select {
case <-stopCh:
// stopCh channel is already closed
default:
close(stopCh)
}
}
func (m *EngineMonitor) Run() {
m.logger.Info("Starting monitoring engine")
defer func() {
if err := m.acquireRestoringCounter(false); err != nil {
m.logger.WithError(err).Error("Failed to unacquire restoring counter")
}
m.logger.Info("Stopping monitoring engine")
close(m.monitorVoluntaryStopCh)
}()
ticker := time.NewTicker(EnginePollInterval)
defer ticker.Stop()
for {
select {
case <-ticker.C:
if needStop := m.sync(); needStop {
return
}
case <-m.stopCh:
return
}
}
}
func (m *EngineMonitor) sync() bool {
for count := 0; count < EngineMonitorConflictRetryCount; count++ {
engine, err := m.ds.GetEngine(m.Name)
if err != nil {
if datastore.ErrorIsNotFound(err) {
m.logger.Warn("Stopping monitoring because the engine no longer exists")
return true
}
utilruntime.HandleError(errors.Wrapf(err, "failed to get engine %v for monitoring", m.Name))
return false
}
if engine.Status.OwnerID != m.controllerID {
m.logger.Warnf("Stopping monitoring the engine on this node (%v) because the engine has new ownerID %v", m.controllerID, engine.Status.OwnerID)
return true
}
// engine is maybe starting
if engine.Status.CurrentState != longhorn.InstanceStateRunning {
return false
}
// engine is upgrading
if engine.Status.CurrentImage != engine.Spec.Image || len(engine.Spec.UpgradedReplicaAddressMap) != 0 {
return false
}
if err := m.refresh(engine); err == nil || !apierrors.IsConflict(errors.Cause(err)) {
utilruntime.HandleError(errors.Wrapf(err, "failed to update status for engine %v", m.Name))
break
}
// Retry if the error is due to conflict
}
return false
}
func (m *EngineMonitor) refresh(engine *longhorn.Engine) error {
existingEngine := engine.DeepCopy()
addressReplicaMap := map[string]string{}
for replica, address := range engine.Status.CurrentReplicaAddressMap {
if addressReplicaMap[address] != "" {
return fmt.Errorf("invalid ReplicaAddressMap: duplicate addresses")
}
addressReplicaMap[address] = replica
}
engineCliClient, err := GetBinaryClientForEngine(engine, m.engines, engine.Status.CurrentImage)
if err != nil {
return err
}
engineClientProxy, err := engineapi.GetCompatibleClient(engine, engineCliClient, m.ds, m.logger, m.proxyConnCounter)
if err != nil {
return err
}
defer engineClientProxy.Close()
replicaURLModeMap, err := engineClientProxy.ReplicaList(engine)
if err != nil {
return err
}
currentReplicaModeMap := map[string]longhorn.ReplicaMode{}
for url, r := range replicaURLModeMap {
addr := engineapi.GetAddressFromBackendReplicaURL(url)
replica, exists := addressReplicaMap[addr]
if !exists {
// we have a entry doesn't exist in our spec
replica = unknownReplicaPrefix + url
// The unknown replica will remove and record the event during
// ReconcileEngineState.
// https://github.com/longhorn/longhorn/issues/4120
currentReplicaModeMap[replica] = r.Mode
m.logger.Warnf("Found unknown replica %v in the Replica URL Mode Map", addr)
continue
}
currentReplicaModeMap[replica] = r.Mode
if engine.Status.ReplicaModeMap != nil {
if r.Mode != engine.Status.ReplicaModeMap[replica] {
switch r.Mode {
case longhorn.ReplicaModeERR:
m.eventRecorder.Eventf(engine, corev1.EventTypeWarning, constant.EventReasonFaulted, "Detected replica %v (%v) in error", replica, addr)
case longhorn.ReplicaModeWO:
m.eventRecorder.Eventf(engine, corev1.EventTypeNormal, constant.EventReasonRebuilding, "Detected rebuilding replica %v (%v)", replica, addr)
case longhorn.ReplicaModeRW:
m.eventRecorder.Eventf(engine, corev1.EventTypeNormal, constant.EventReasonRebuilt, "Detected replica %v (%v) has been rebuilt", replica, addr)
default:
m.logger.Errorf("Invalid engine replica mode %v", r.Mode)
}
}
}
}
engine.Status.ReplicaModeMap = currentReplicaModeMap
snapshots, err := engineClientProxy.SnapshotList(engine)
if err != nil {
engine.Status.SnapshotsError = err.Error()
} else {
engine.Status.Snapshots = snapshots
engine.Status.SnapshotsError = ""
}
// TODO: find a more advanced way to handle invocations for incompatible running engines
im, err := m.ds.GetInstanceManagerRO(engine.Status.InstanceManagerName)
if err != nil {
return err
}
cliAPIVersion, err := m.ds.GetDataEngineImageCLIAPIVersion(engine.Status.CurrentImage, engine.Spec.DataEngine)
if err != nil {
return err
}
if (datastore.IsDataEngineV1(engine.Spec.DataEngine) && cliAPIVersion >= engineapi.CLIAPIMinVersionForExistingEngineBeforeUpgrade) ||
datastore.IsDataEngineV2(engine.Spec.DataEngine) {
volumeInfo, err := engineClientProxy.VolumeGet(engine)
if err != nil {
return err
}
endpoint, err := engineapi.GetEngineEndpoint(volumeInfo, engine.Status.IP)
if err != nil {
return err
}
engine.Status.Endpoint = endpoint
if volumeInfo.LastExpansionError != "" && volumeInfo.LastExpansionFailedAt != "" &&
(engine.Status.LastExpansionError != volumeInfo.LastExpansionError ||
engine.Status.LastExpansionFailedAt != volumeInfo.LastExpansionFailedAt) {
isLatestErrorInfo := true
if expansionFailureTime, err := time.Parse(time.RFC3339Nano, volumeInfo.LastExpansionFailedAt); err == nil && m.expansionUpdateTime.After(expansionFailureTime) {
isLatestErrorInfo = false
}
if isLatestErrorInfo {
m.eventRecorder.Eventf(engine, corev1.EventTypeWarning, constant.EventReasonFailedExpansion,
"Engine failed or partially failed to expand the size at %v: %v", volumeInfo.LastExpansionFailedAt, volumeInfo.LastExpansionError)
engine.Status.LastExpansionError = volumeInfo.LastExpansionError
engine.Status.LastExpansionFailedAt = volumeInfo.LastExpansionFailedAt
m.expansionUpdateTime = time.Now()
m.expansionBackoff.Next(engine.Name, time.Now())
}
}
if engine.Status.CurrentSize != 0 && engine.Status.CurrentSize != volumeInfo.Size {
m.eventRecorder.Eventf(engine, corev1.EventTypeNormal, constant.EventReasonSucceededExpansion,
"Engine successfully expand size from %v to %v", engine.Status.CurrentSize, volumeInfo.Size)
m.expansionUpdateTime = time.Now()
}
engine.Status.CurrentSize = volumeInfo.Size
engine.Status.IsExpanding = volumeInfo.IsExpanding
if engine.Status.Endpoint == "" && !engine.Spec.DisableFrontend && engine.Spec.Frontend != longhorn.VolumeFrontendEmpty {
m.logger.Infof("Starting frontend %v", engine.Spec.Frontend)
if err := engineClientProxy.VolumeFrontendStart(engine); err != nil {
return errors.Wrapf(err, "failed to start frontend %v", engine.Spec.Frontend)
}
}
// The rebuild failure will be handled by ec.startRebuilding()
rebuildStatus, err := engineClientProxy.ReplicaRebuildStatus(engine)
if err != nil {
return err
}
engine.Status.RebuildStatus = rebuildStatus
// It's meaningless to sync the trim related field for old engines or engines in old engine instance managers
if cliAPIVersion >= 7 && im.Status.APIVersion >= 3 {
// Check and correct flag UnmapMarkSnapChainRemoved for the engine and replicas
engine.Status.UnmapMarkSnapChainRemovedEnabled = volumeInfo.UnmapMarkSnapChainRemoved
if engine.Spec.UnmapMarkSnapChainRemovedEnabled != volumeInfo.UnmapMarkSnapChainRemoved {
if err := engineClientProxy.VolumeUnmapMarkSnapChainRemovedSet(engine); err != nil {
return errors.Wrapf(err, "failed to correct flag UnmapMarkSnapChainRemoved from %v to %v",
volumeInfo.UnmapMarkSnapChainRemoved, engine.Spec.UnmapMarkSnapChainRemovedEnabled)
}
}
}
if cliAPIVersion >= 10 && im.Status.APIVersion >= 5 {
engine.Status.SnapshotMaxCount = volumeInfo.SnapshotMaxCount
if engine.Spec.SnapshotMaxCount != volumeInfo.SnapshotMaxCount {
logrus.Infof("Correcting flag SnapshotMaxCount from %d to %d", volumeInfo.SnapshotMaxCount, engine.Spec.SnapshotMaxCount)
if err := engineClientProxy.VolumeSnapshotMaxCountSet(engine); err != nil {
return errors.Wrapf(err, "failed to correct flag SnapshotMaxCount from %d to %d",
volumeInfo.SnapshotMaxCount, engine.Spec.SnapshotMaxCount)
}