Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Backup/Restore Longhorn System #1455

Closed
yasker opened this issue Jun 4, 2020 · 5 comments
Closed

[FEATURE] Backup/Restore Longhorn System #1455

yasker opened this issue Jun 4, 2020 · 5 comments
Assignees
Labels
area/volume-disaster-recovery Volume DR highlight Important feature/issue to highlight kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) release/note Note for installation, upgrade and highlighted issues require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@yasker
Copy link
Member

yasker commented Jun 4, 2020

Rancher has introduced ETCD snapshot/restore, but we found that it doesn't work well with Longhorn. More importantly, there is currently no recommended way to backup the Longhorn system itself. It can be useful for the following scenarios:

  1. Rollback in the case of an upgrade failure.
  2. Recreate/replicate the cluster

In general, we can dump the related CRDs and rollback to them if something went wrong.

It requires some designs to offer the best experience to the end user.

REF: #1648

@yasker yasker added kind/feature Feature request, new feature area/install-uninstall-upgrade Install, Uninstall or Upgrade related highlight Important feature/issue to highlight release/note Note for installation, upgrade and highlighted issues priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated labels Jun 4, 2020
@yasker yasker added this to the v1.1.0 milestone Jun 4, 2020
@yasker yasker added the require/lep Require adding/updating enhancement proposal label Jun 12, 2020
@yasker yasker assigned ttpcodes and unassigned shuo-wu Jul 21, 2020
@yasker yasker modified the milestones: v1.1.0, v1.2.0 Aug 17, 2020
@yasker yasker changed the title [FEATURE] Support upgrade rollback [FEATURE] Backup/restore Longhorn system itself Dec 21, 2020
@innobead innobead modified the milestones: v1.2.0, v1.3.0 Apr 29, 2021
@innobead innobead modified the milestones: v1.3.0, Backlog Oct 20, 2021
@innobead innobead modified the milestones: Backlog, v1.4.0 Apr 26, 2022
@c3y1huang
Copy link
Contributor

c3y1huang commented Aug 2, 2022

Note: @FrankYang0529 is currently working on backing image backup and restore. AFAIK the implementation will have:

  1. New backup cmd to the backing image manager to upload to the backup targets.
  2. New fields ex:lastBackingImage... to the related CR

For this issue, we can leverage the field lastBackingImage for rollout restore.

Relate issue #4165, harvester/harvester#2237

cc @innobead @shuo-wu

@c3y1huang
Copy link
Contributor

Backing image backup/restore, ref #4385.

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Oct 26, 2022

Pre Ready-For-Testing Checklist

@innobead innobead changed the title [FEATURE] Backup/restore Longhorn system itself [FEATURE] Backup/Restore Longhorn System Nov 14, 2022
@c3y1huang c3y1huang added require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated and removed require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated labels Nov 23, 2022
@innobead innobead added area/volume-disaster-recovery Volume DR and removed area/install-uninstall-upgrade Install, Uninstall or Upgrade related labels Dec 3, 2022
@khushboo-rancher
Copy link
Contributor

khushboo-rancher commented Dec 13, 2022

Validation - PASS

Verified below scenarios and tests from longhorn/longhorn-tests#1191 on v1.4.x-head

  1. Backup creation and deletion - PASS
  2. Restore creation and deletion - PASS
  3. Empty backup target handling - PASS
  4. Backup and restore with RWO volume (Created using sc, LH GUI, vch template - PASS
  5. Backup and restore of RWX volume - PASS
  6. Backup and Restore of volume with backing image - FAIL - [IMPROVEMENT] System restore unable to restore volume with backing image #5085
  7. Restore in same cluster and new cluster - PASS
  8. Backup & Restore in upgraded set up - PASS
  9. Backup & Restore of volumes with setting changes - PASS
  10. Backup & restore of 50 volumes - PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/volume-disaster-recovery Volume DR highlight Important feature/issue to highlight kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) release/note Note for installation, upgrade and highlighted issues require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Development

No branches or pull requests

7 participants