Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] e2e test_instance_manager_cpu_reservation failed #2325

Closed
c3y1huang opened this issue Mar 11, 2021 · 2 comments
Closed

[BUG] e2e test_instance_manager_cpu_reservation failed #2325

c3y1huang opened this issue Mar 11, 2021 · 2 comments
Assignees
@c3y1huang @shuo-wu
Labels
kind/bug
Milestone
v1.1.1

Comments

@c3y1huang
Copy link
Contributor

c3y1huang commented Mar 11, 2021 •
edited

Describe the bug
The test_instance_manager_cpu_reservation needs to be updated for Enhanced resource reservation mechanism.

To Reproduce
Steps to reproduce the behavior:

  1. Run test_instance_manager_cpu_reservation

Expected behavior
Should pass

Log
n/a

Environment:
n/s

Additional context
https://github.com/longhorn/longhorn-tests/blob/master/manager/integration/tests/test_settings.py#L315-L317

https://github.com/longhorn/longhorn-manager/pull/828/files#diff-be348ed45296f49335ad1afc4a80cdcb18350cbcbbf701a740c2f400e6c31407L204-L205
@c3y1huang
Copy link
Contributor Author

c3y1huang commented Mar 11, 2021 •
edited

@shuo-wu , as discussed, could you please help to provide an update of this test skeleton?

@yasker yasker added this to the v1.1.1 milestone Mar 11, 2021
@c3y1huang c3y1huang mentioned this issue Mar 12, 2021
Merged
@c3y1huang c3y1huang removed their assignment Mar 12, 2021
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Mar 12, 2021 •
edited by shuo-wu

Pre-merged Checklist

  • Is the reproduce steps/test steps documented?

  • Is there a workaround for the issue? If so, is it documented?

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, have both YAML file and Chart been updated in the PR?

  • Is the backend code merged (Manager, Engine, Instance Manager, BackupStore etc)?
    The PR is at Fix one typo for the CPU reservation longhorn-manager#843

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged?
    The Doc issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case?
    The automation skeleton PR is at
    The automation test case PR is at integration: Fix test_instance_manager_cpu_reservation longhorn-tests#555

  • If labeled: require/automation-engine Has the engine integration test been merged?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has an separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@c3y1huang c3y1huang self-assigned this Mar 12, 2021
@shuo-wu shuo-wu mentioned this issue Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c3y1huang c3y1huang

@shuo-wu shuo-wu

Labels
kind/bug
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
5 participants
@innobead @yasker @c3y1huang @shuo-wu @longhorn-io-github-bot