Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Expansion of volume is allowed beyond the available allocated storage on the node. #2689

Closed
khushboo-rancher opened this issue Jun 14, 2021 · 2 comments
Labels
component/longhorn-manager Longhorn manager (control plane) duplicated kind/bug reproduce/always 100% reproducible severity/3 Function working but has a major issue w/ workaround

Comments

@khushboo-rancher
Copy link
Contributor

khushboo-rancher commented Jun 14, 2021

Describe the bug
There is no check on available storage on the nodes before doing the expansion of volumes.

To Reproduce
Steps to reproduce the behavior:

  1. Create a cluster with node config - 60 GB storage.
  2. Make sure the Storage Over Provisioning Percentage is set to default value 200.
  3. Create a volume of 10 GB.
  4. Expand the volume to 400 GB
  5. The volume gets expanded successfully and there is no warning shown.
    Allowing user to expand volume with no limit can cause problem to the set up in terms of miss management of the storage.

Screen Shot 2021-06-14 at 3 19 27 PM

Expected behavior
Expansion beyond the available storage should not be allowed and UI should warn user for doing so.

Environment:

  • Longhorn version: v1.1.2-head
  • Installation method (e.g. Rancher Catalog App/Helm/Kubectl): kubectl
  • Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: v1.20.7-Rke1
    • Number of management node in the cluster:1
    • Number of worker node in the cluster: 3
@khushboo-rancher khushboo-rancher added kind/bug reproduce/always 100% reproducible severity/3 Function working but has a major issue w/ workaround labels Jun 14, 2021
@innobead innobead added the component/longhorn-manager Longhorn manager (control plane) label Jun 15, 2021
@innobead innobead added this to the v1.2.0 milestone Jun 15, 2021
@joshimoo
Copy link
Contributor

This should be checked as part of the ExpansionApi call

@innobead
Copy link
Member

Duplicated of #2962

@innobead innobead removed this from the v1.3.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/longhorn-manager Longhorn manager (control plane) duplicated kind/bug reproduce/always 100% reproducible severity/3 Function working but has a major issue w/ workaround
Projects
None yet
Development

No branches or pull requests

5 participants