Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] longhorn-engine image no longer contains longhorn-instance manager #2796

Closed
keithalucas opened this issue Jul 13, 2021 · 2 comments
Closed
Assignees
Labels
area/v1-data-engine v1 data engine (iSCSI tgt) backport/1.1.3 Require to backport to 1.1.3 release branch kind/bug kind/regression Regression which has worked before priority/0 Must be fixed in this release (managed by PO)
Milestone

Comments

@keithalucas
Copy link

Describe the bug
longhorn/longhorn-engine@0224acb removed longhorn-instance-manager from the longhorn-engine image. longhorn-instance-manager is used by the launch-simple-file and launch-simple-longhorn scripts in /usr/local/bin.

To Reproduce
Steps to reproduce the behavior:

  1. docker image pull longhornio/longhorn-engine:v1.1.2
  2. docker run -it longhornio/longhorn-engine:v1.1.2 ls /usr/local/bin/
  3. See that longhorn-instance-manager isn't in the output.

Expected behavior
longhorn-instance-manager should be in /usr/local/bin in order for launch-simple-file and launch-simple-longhorn to work.

Log
N/A

Environment:

  • Longhorn version: v1.1.2
  • Installation method (e.g. Rancher Catalog App/Helm/Kubectl): N/A
  • Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: N/A
    • Number of management node in the cluster: N/A
    • Number of worker node in the cluster: N/A
  • Node config
    • OS type and version: N/A
    • CPU per node: N/A
    • Memory per node: N/A
    • Disk type(e.g. SSD/NVMe): N/A
    • Network bandwidth between the nodes: N/A
  • Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): N/A
  • Number of Longhorn volumes in the cluster: N/A

Additional context

@yasker yasker added this to the v1.2.0 milestone Jul 13, 2021
@yasker yasker added the area/v1-data-engine v1 data engine (iSCSI tgt) label Jul 13, 2021
@yasker
Copy link
Member

yasker commented Jul 13, 2021

Also, https://longhorn.io/docs/1.1.2/advanced-resources/data-recovery/export-from-replica/ won't work for v1.1.2 due to launch-simple-longhorn won't work.

@yasker yasker added priority/0 Must be fixed in this release (managed by PO) kind/regression Regression which has worked before labels Jul 13, 2021
@innobead innobead added the backport/1.1.3 Require to backport to 1.1.3 release branch label Jul 14, 2021
@khushboo-rancher
Copy link
Contributor

Verified with master-head 07/27/2021 and v1.1.3-head 07/27/2021

Validation - Pass

Validated with launch-simple-longhorn, It worked with master-head and v1.1.3-head

> docker run -it longhornio/longhorn-engine:master-head ls /usr/local/bin/
engine-manager	   launch-simple-file	   longhorn
grpc_health_probe  launch-simple-longhorn  longhorn-instance-manager

> docker run -it longhornio/longhorn-engine:v1.1.3-head ls /usr/local/bin/
engine-manager	   launch-simple-file	   longhorn
grpc_health_probe  launch-simple-longhorn  longhorn-instance-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v1-data-engine v1 data engine (iSCSI tgt) backport/1.1.3 Require to backport to 1.1.3 release branch kind/bug kind/regression Regression which has worked before priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Development

No branches or pull requests

4 participants