Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tests related to backup failed on nightly test run #3216

Closed
khushboo-rancher opened this issue Nov 3, 2021 · 3 comments
Closed

[BUG] Tests related to backup failed on nightly test run #3216

khushboo-rancher opened this issue Nov 3, 2021 · 3 comments
Assignees
Labels
kind/bug kind/regression Regression which has worked before priority/0 Must be fixed in this release (managed by PO) severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Milestone

Comments

@khushboo-rancher
Copy link
Contributor

khushboo-rancher commented Nov 3, 2021

Describe the bug
All the tests related to backup are failing on master-head.
https://ci.longhorn.io/job/public/job/master/job/ubuntu/job/amd64/job/longhorn-tests-ubuntu-amd64/477/

Looks like the backups are stuck and didn't complete.

To Reproduce
Steps to reproduce the behavior:

  1. Run any test related to backups.

Expected behavior
The backup should complete properly.

Log

def wait_for_backup_completion(client, volume_name, snapshot_name=None,
                                   retry_count=RETRY_BACKUP_COUNTS):
        completed = False
        for _ in range(retry_count):
            v = client.by_id_volume(volume_name)
            for b in v.backupStatus:
                if snapshot_name is not None and b.snapshot != snapshot_name:
                    continue
                if b.state == "complete":
                    assert b.progress == 100
                    assert b.error == ""
                    completed = True
                    break
            if completed:
                break
            time.sleep(RETRY_BACKUP_INTERVAL)
>       assert completed is True
E       AssertionError
[longhorn-manager-jdqgk] time="2021-11-03T21:35:14Z" level=error msg="failed to get backup status" controller=longhorn-engine engine=pvc-1caf0f63-3c4c-4214-b915-c2039d571894-e-cc3e2f3f error="failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-master-head/longhorn [--url 10.42.2.6:10001 backup status], output , stderr, time=\"2021-11-03T21:35:14Z\" level=fatal msg=\"Error querying backup status: Missing required parameter backupID\"\n, error exit status 1" node=ip-172-31-3-38

Environment:

  • Longhorn version: master-head 11/03/2021
@khushboo-rancher khushboo-rancher added kind/bug severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade) priority/0 Must be fixed in this release (managed by PO) kind/regression Regression which has worked before labels Nov 3, 2021
@PhanLe1010
Copy link
Contributor

After meeting with @khushboo-rancher , we found out that it was because this engine commit is merged while the Longhorn manager is not merged longhorn/longhorn-manager#1107

@innobead
Copy link
Member

innobead commented Nov 4, 2021

@innobead innobead added this to the v1.3.0 milestone Nov 4, 2021
@khushboo-rancher
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/regression Regression which has worked before priority/0 Must be fixed in this release (managed by PO) severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Projects
None yet
Development

No branches or pull requests

4 participants