[BUG] Misleading log "BUG: replica is running but storage IP is empty"

[shuo-wu]

Describe the bug

The below log is misleading:

time="2022-06-20T03:26:19Z" level=error msg="BUG: replica is running but storage IP is empty" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false n

It will be printed when the system containing volumes is upgraded to v1.3.0.

To Reproduce

Steps to reproduce the behavior:

1. Deploy Longhorn v1.2.x
2. Create one volume
3. Upgrade Longhorn to v1.3.0
4. Check the longhorn manager pod logs and search the error message BUG: replica is running but storage IP is empty

Expected behavior

There should not be this kind of logs

Log or Support bundle

time="2022-06-20T03:26:19Z" level=error msg="BUG: replica is running but storage IP is empty" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false n

Environment

• Longhorn version: v1.2.x -> v1.3.0

Additional context

This is reported in #4134

[longhorn-io-github-bot]

Pre Ready-For-Testing Checklist

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at: the ticket description

• Does the PR include the explanation for the fix or the feature?

• Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
  The PR is at controller: Fix the misleading log for the replicas that have no StorageIP longhorn-manager#1389

• If labeled: require/manual-test-plan Has the manual test plan been documented?
  The updated manual test plan is the same as the reproducing step

[chriscchien]

Hi @shuo-wu ,

I tested with master-head, after upgrade LH from v1.2.4 to master-head, got log below

time="2022-06-21T04:15:32Z" level=debug msg="Replica is running but storage IP is empty, need to wait for update" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=worker4 owner=worker4 replica=vol2-r-79603e7a state=attached volume=vol

The content still present but log level changed from error to debug, reference to this PR, I think this is correct behavior?

If it's OK I'll close thsi issue, thank you

[shuo-wu]

This message is the correct one. I can close this now.

[innobead]

@cchien816 We need to verify on 1.3.x as well. Please create a backport issue for that. Thanks.

[shuo-wu]

@innobead The backported issue ticket is already there: #4156