Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach support for Flexvolume driver #43

Closed
yasker opened this issue Mar 28, 2018 · 1 comment
Closed

Attach support for Flexvolume driver #43

yasker opened this issue Mar 28, 2018 · 1 comment
Labels
component/longhorn-manager Longhorn manager (control plane) kind/feature Feature request, new feature wontfix
Milestone

Comments

@yasker
Copy link
Member

yasker commented Mar 28, 2018

We may need to support attach/detach in addition to current mount/umount. When Kubernetes think one pod is down on one node, it will create the same pod on another node. In the process, Kubernetes will try to detach the PVC from volume if possible, then attach to the new node and use it for the restarted pod.

Flexvolume document regarding attach support https://github.com/kubernetes/community/blob/master/contributors/devel/flexvolume.md#driver-invocation-model

But it also mentioned that
This call-out (attach) does not pass "secrets" specified in Flexvolume spec. If your driver requires secrets, do not implement this call-out and instead use "mount" call-out and implement attach and mount in that call-out.

Need to check if it's worth doing it, or simply do detach inside mount call is enough.

@yasker yasker added this to the v0.3 milestone Mar 28, 2018
@yasker yasker added kind/feature Feature request, new feature component/longhorn-manager Longhorn manager (control plane) wontfix labels Mar 28, 2018
@yasker
Copy link
Member Author

yasker commented Mar 29, 2018

Skip this. Replace it with #50

We're switching to CSI for v1.10+.

  1. It has been marked as beta in v1.10.
  2. The deployment directory is not detectible for flexvolume after v1.9.

@yasker yasker closed this as completed Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/longhorn-manager Longhorn manager (control plane) kind/feature Feature request, new feature wontfix
Projects
None yet
Development

No branches or pull requests

1 participant