Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Refresh distro version support for 1.4 #4401

Closed
1 of 2 tasks
innobead opened this issue Aug 11, 2022 · 4 comments
Closed
1 of 2 tasks

[TASK] Refresh distro version support for 1.4 #4401

innobead opened this issue Aug 11, 2022 · 4 comments
Assignees
Labels
kind/task General task request to fulfill another primary request priority/2 Nice to fix in this release (managed by PO) require/doc Require updating the longhorn.io documentation
Milestone

Comments

@innobead
Copy link
Member

innobead commented Aug 11, 2022

What's the task? Please describe

Longhorn supports FS volume which actually relies on some kernel modules to achieve that like ext4 and xfs. In different distros w/ different Kernel versions, probably there will some compatibility problems like unsupported mount options to cause the volume mount to fail. The doc needs to update to ensure people understand the criteria for the host kernel.

Describe the items of the task (DoD, definition of done) you'd like

Additional context

#2640
ceph/ceph-csi#966 (comment)

cc @longhorn/qa @PhanLe1010 @derekbit

@innobead innobead added priority/0 Must be fixed in this release (managed by PO) require/doc Require updating the longhorn.io documentation kind/task General task request to fulfill another primary request labels Aug 11, 2022
@innobead innobead added this to the v1.4.0 milestone Aug 11, 2022
@joshimoo
Copy link
Contributor

We previously had a similiar issuse to support an older suse distro.
#1208 (comment)

We also previously had the slow extents retrieval on EXT4 linked above already.
#2640
#2507 (comment)

If we want to allow usage on a older kernel we can add a fsParam to the storage class to allow the user to specify custom params. Since a storage class always only uses a single fsType that would make sense. Since I already wrote the paramOverrider for EXT4 we can deprecate the setting and instead allow the users to use the fsParam on the storage class.
We can use a similiar approach to allow the user to specify args for the fsCHK when provided.

Just for future reference one can create a xfs fs on the older kernels by passing:
-m reflink=0 to the mkfs.xfs call.

@innobead innobead added priority/2 Nice to fix in this release (managed by PO) and removed priority/0 Must be fixed in this release (managed by PO) labels Sep 20, 2022
@weizhe0422
Copy link
Contributor

According to the conclusion of the last meeting, since the fs type will continue to be backported in the Linux kernel.

So the task will add a check function to the environment_check.sh to check the supported fs types, currently ext4 and xfs.

@innobead
Copy link
Member Author

ref: #4642

@innobead innobead changed the title [TASK] Have min kernel version in the doc and refresh distro version support [TASK] Refresh distro version support for 1.4 Oct 13, 2022
@innobead
Copy link
Member Author

innobead commented Oct 13, 2022

Don't really need to figure out the min Kernel support but rather provide a flexible way to let users customize fs parameters, so let's focus on #4642.

@yangchiu has updated the distro version to 1.4.0 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task General task request to fulfill another primary request priority/2 Nice to fix in this release (managed by PO) require/doc Require updating the longhorn.io documentation
Projects
None yet
Development

No branches or pull requests

3 participants