Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] v2 volume replica management #5420

Closed
innobead opened this issue Feb 21, 2023 · 5 comments 路 Fixed by longhorn/spdk#19
Closed

[FEATURE] v2 volume replica management #5420

innobead opened this issue Feb 21, 2023 · 5 comments 路 Fixed by longhorn/spdk#19
Assignees
Labels
area/v2-data-engine v2 data engine (SPDK) kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO)
Milestone

Comments

@innobead
Copy link
Member

innobead commented Feb 21, 2023

Is your feature request related to a problem? Please describe (馃憤 if you like this request)

Support managing replicas (add/remove/get/replace) of each RAID1 bdev and ensure non-disruptive IO during management if the volume is degraded.

Describe the solution you'd like

Have RPC commands for replica management. Each replica initialization still needs to manage by longhorn-spdk-engine.

Additional context

cc @longhorn/dev-data-plane

@innobead innobead added kind/feature Feature request, new feature area/v2-data-engine v2 data engine (SPDK) labels Feb 21, 2023
@innobead innobead added this to the v1.5.0 milestone Feb 21, 2023
@innobead innobead changed the title [FEATURE] Have a RPC command for replica management at longhorn bdev [FEATURE] Longhorn bdev replica management Feb 21, 2023
@innobead innobead added priority/0 Must be fixed in this release (managed by PO) areea/spdk-engine labels Feb 21, 2023
@innobead innobead changed the title [FEATURE] Longhorn bdev replica management [FEATURE] Manage replicas of longhorn bdev Feb 21, 2023
@DamiaSan DamiaSan changed the title [FEATURE] Manage replicas of longhorn bdev [FEATURE] Manage replicas of raid1 bdev Feb 21, 2023
@DamiaSan
Copy link
Contributor

There is a development under review to remove base bdev from RAID1:
https://review.spdk.io/gerrit/c/spdk/spdk/+/15267/35

@DamiaSan
Copy link
Contributor

DamiaSan commented Feb 21, 2023

For the functionality to add a base bdev, we are waiting that the development will be put under code review: #5387
If this development will not be ready soon, we will proceed on our own

@innobead
Copy link
Member Author

For the functionality to add a base bdev, we are waiting that the development will be put under code review: #5387 If this development will not be ready soon, we will proceed on our own

I transfer this issue to EPIC and include #5387 in this EPIC. I only see https://review.spdk.io/gerrit/c/spdk/spdk/+/15267, anything else? It seems pending for a while, I believe we should start the downstream first. This is mandatory for us in 1.5.0.

cc @shuo-wu @derekbit

@DamiaSan
Copy link
Contributor

I agree, we will develop this functionality in downstream

@innobead innobead changed the title [FEATURE] Manage replicas of raid1 bdev [FEATURE] Manage replicas of RAID1 bdev Apr 13, 2023
@innobead innobead removed the Epic label Apr 13, 2023
@innobead innobead modified the milestones: v1.5.0, v1.6.0 Apr 27, 2023
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jul 21, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The documentation of the needed RAID1 functionality, like add and remove of a base bdev, can be found in the jsonrpc.md file
  • Which areas/issues this PR might have potential impacts on?
    Area SPDK

@DamiaSan DamiaSan linked a pull request Jul 21, 2023 that will close this issue
@DamiaSan DamiaSan removed a link to a pull request Sep 5, 2023
@DamiaSan DamiaSan linked a pull request Sep 5, 2023 that will close this issue
@innobead innobead changed the title [FEATURE] Manage replicas of RAID1 bdev [FEATURE] v2 volume replica management Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2-data-engine v2 data engine (SPDK) kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants