Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Webhook PDBs are not removed after upgrading to master-head #6026

Closed
PhanLe1010 opened this issue May 30, 2023 · 2 comments
Closed

[BUG] Webhook PDBs are not removed after upgrading to master-head #6026

PhanLe1010 opened this issue May 30, 2023 · 2 comments
Assignees
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/bug
Milestone

Comments

@PhanLe1010
Copy link
Contributor

PhanLe1010 commented May 30, 2023

To Reproduce

  1. DeployLonghorn v1.4.2. Create and attach some Longhorn volumes
  2. Update Longhorn to master-head. Delete all Longhorn volumes
  3. Observe that longhorn-admission-webhook and longhorn-conversion-webhook PDBs are not removed

Expected behavior

Observe that longhorn-admission-webhook and longhorn-conversion-webhook PDBs are removed

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented May 31, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: issue description

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at Remove webhook PDBs in the upgrade path from v1.4.x to v1.5.0 longhorn-manager#1932

  • Which areas/issues this PR might have potential impacts on?
    Area Kubernetes upgrade/Node maitainance
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@innobead innobead added the area/install-uninstall-upgrade Install, Uninstall or Upgrade related label May 31, 2023
@innobead innobead changed the title [BUG] webhook PDBs are not removed after upgrading to master-head [BUG] Webhook PDBs are not removed after upgrading to master-head Jun 1, 2023
@weizhe0422
Copy link
Contributor

Verified on master-head 20230601

Result: PASSED

Test steps:

  1. Install Longhorn V1.4.2, and create two volumes with writing some data into mount point
    image
    • check that the PDBs for longhorn-admission-webhook and longhorn-conversion-webhook exist
      image
  2. Upgrade Longhorn to master branch build withing using kubectl apply -f https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml
    • The PDBs for longhorn-admission-webhook and longhorn-conversion-webhook are gone after upgrading
      image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/bug
Projects
None yet
Development

No branches or pull requests

4 participants