Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] UI supports automatic replica rebuilding for SPDK volumes #6107

Closed
derekbit opened this issue Jun 12, 2023 · 7 comments
Closed
Assignees
Labels
area/ui UI related like UI or CLI area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/2 Nice to fix in this release (managed by PO)
Milestone

Comments

@derekbit
Copy link
Member

Is your improvement request related to a feature? Please describe (👍 if you like this request)

SPDK volumes support per-volume automatic replica rebuilding, so UI needs some updates

  • Can specify Volume.Spec.OfflineReplicaRebuilding when creating a volume. The values are

    • ignored (default value)
    • disabled
    • enabled
  • Volume page can change volume.Spec.OfflineReplicaRebuilding

  • If a SPDK volume is degraded, should a warning message remaindering users that replica rebuilding will be automatically triggered when the degraded volume is detached

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

#6071

@derekbit derekbit added area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) labels Jun 12, 2023
@innobead innobead added this to the v1.5.0 milestone Jun 12, 2023
@innobead innobead added the priority/2 Nice to fix in this release (managed by PO) label Jun 13, 2023
@derekbit
Copy link
Member Author

derekbit commented Jun 14, 2023

To improve UX, the implementation adds a hint for offline replica building

image

WDYT @innobead @shuo-wu

@shuo-wu
Copy link
Contributor

shuo-wu commented Jun 14, 2023

BTW, when a SPDK volume is degraded, can we add a similar hint to inform users that, the rebuilding will be triggered when the volume is in maintenance mode?

@innobead
Copy link
Member

UX LGTM

@derekbit
Copy link
Member Author

BTW, when a SPDK volume is degraded, can we add a similar hint to inform users that, the rebuilding will be triggered when the volume is in maintenance mode?

Hello @smallteeths
Can you help with the idea?
If a spdk volume is attached, degraded and disableFrontend=false, add a hint for users.
Thank you.

@smallteeths
Copy link
Contributor

BTW, when a SPDK volume is degraded, can we add a similar hint to inform users that, the rebuilding will be triggered when the volume is in maintenance mode?

Hello @smallteeths Can you help with the idea? If a spdk volume is attached, degraded and disableFrontend=false, add a hint for users. Thank you.

Ok

The UI condition for judgment is as follows.

!volume.disableFrontend && volume.backendStoreDriver === ‘spdk’ && volume.state === ‘attached’

Add alert The volume rebuilding will be triggered

@innobead
Copy link
Member

Moving to ready for testing, QA can follow the description to verify the UI part.

@roger-ryao
Copy link

Verified on v1.5.x-head 20230619

Verified on master-head 20230619

Result Passed

  • After creating a volume, we can verify that the Offline Replica Rebuilding option values ignored (default value), disabled, and enabled are shown in the Longhorn UI.
  • We can update the Offline Replica Rebuilding on the volume page.
  • When a SPDK volume is degraded, a warning message will remind users that The volume rebuilding will be automatically triggered after detachment.
    Screenshot_20230619_131544

Screenshot_20230619_135731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui UI related like UI or CLI area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/2 Nice to fix in this release (managed by PO)
Projects
None yet
Development

No branches or pull requests

5 participants