Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update or remove out-of-date cleanup script #6316

Closed
1 task
james-munson opened this issue Jul 13, 2023 · 5 comments
Closed
1 task

[TASK] Update or remove out-of-date cleanup script #6316

james-munson opened this issue Jul 13, 2023 · 5 comments
Assignees
Labels
area/dev Development related kind/task General task request to fulfill another primary request
Milestone

Comments

@james-munson
Copy link
Contributor

What's the task? Please describe

longhorn/scripts/cleanup.sh is out of date with respect to the resources that make up a Longhorn installation.

A clear and concise description of what the task is.
Either

  • Bring it up to date, including changes to the resource list and also ability to deal with pending finalizers
    Or
  • Remove it from the repo.

Describe the items of the task (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

  • item 1

Additional context

Add any other context or screenshots about the task request here.

@james-munson james-munson added the kind/task General task request to fulfill another primary request label Jul 13, 2023
@james-munson james-munson self-assigned this Jul 13, 2023
@innobead innobead added this to the v1.6.0 milestone Jul 17, 2023
@innobead innobead added the area/dev Development related label Jul 17, 2023
@innobead
Copy link
Member

@james-munson Please help update zenhub pipeline correctly. If having any questions, consult with @PhanLe1010 or @ejweber .

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jul 17, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    There are none.

  • Is there a workaround for the issue? If so, where is it documented?
    There is no workaround needed, since the only change is to remove a script that clearly is not in use anywhere.

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? No. If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    Not required.

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    Not needed.

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    Not required (except possibly backport).

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    Not required.

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    Not required.

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    Not required.

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@james-munson james-munson mentioned this issue Jul 18, 2023
@james-munson
Copy link
Contributor Author

How does this ticket get tested and closed?

@PhanLe1010
Copy link
Contributor

cc @khushboo-rancher

In this case, there is no testing needed. Maybe QA just directly close it?

@khushboo-rancher
Copy link
Contributor

Thanks @james-munson @PhanLe1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev Development related kind/task General task request to fulfill another primary request
Projects
None yet
Development

No branches or pull requests

5 participants