Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Ensure the Go version in Dockerfile.dapper matches go.mod for all Longhorn components #7341

Closed
12 tasks done
ejweber opened this issue Dec 15, 2023 · 6 comments
Closed
12 tasks done
Assignees
Labels
area/build-package Build & Package related area/ci CI related (PR, release, etc) kind/task General task request to fulfill another primary request priority/0 Must be fixed in this release (managed by PO)
Milestone

Comments

@ejweber
Copy link
Contributor

ejweber commented Dec 15, 2023

What's the task? Please describe

The go.mod files for most (if not all) Longhorn components references Go 1.21 on the master, v1.5.x, and v1.4.x branches. However, in many cases, the Dockerfile.dapper (which actually determines the version of the Go compiler we will use) references an older version of Go.

Describe the sub-tasks

  • Update longhorn-manager master.
  • Update longhorn-manager v1.5.x.
  • Update longhorn-manager v1.4.x.
  • Update longhorn-instance-manager master.
  • Update longhorn-instance-manager v1.5.x.
  • Update longhorn-instance-manager v1.4.x.
  • Update backing-image-manager master.
  • Update backing-image-manager v1.5.x.
  • Update backing-image-manager v1.4.x.
  • Update share-manager master.
  • Update share-manager v1.5.x.
  • Update share-manager v1.4.x.

I checked the following components, which require no change:

  • longhorn-engine master
  • longhorn-engine v1.5.x
  • longhorn-engine v1.4.x
@ejweber
Copy link
Contributor Author

ejweber commented Dec 15, 2023

I created containers for all components with bumped versions and am running end-to-end tests on all three branches. If the tests pass, we should be safe to merge all the PRs.

@innobead innobead added priority/0 Must be fixed in this release (managed by PO) area/ci CI related (PR, release, etc) labels Dec 18, 2023
@ejweber
Copy link
Contributor Author

ejweber commented Dec 18, 2023

@ejweber
Copy link
Contributor Author

ejweber commented Dec 18, 2023

v1.4.x results link:

v1.4.x results failures:

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 18, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    These changes should have no noticeable impact. If regression testing remains stable, we can close this issue.

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    See all the above linked PRs.

  • Which areas/issues this PR might have potential impacts on?
    Behavioral changes resulting from the Go version change may be subtle and hard to trace back to these PRs.

@innobead
Copy link
Member

All merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-package Build & Package related area/ci CI related (PR, release, etc) kind/task General task request to fulfill another primary request priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Development

No branches or pull requests

3 participants