Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI][FEATURE] Longhorn snapshot space management #7522

Closed
github-actions bot opened this issue Jan 3, 2024 · 6 comments
Closed

[UI][FEATURE] Longhorn snapshot space management #7522

github-actions bot opened this issue Jan 3, 2024 · 6 comments
Assignees
Labels
area/ui UI related like UI or CLI kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Jan 3, 2024

make corresponding UI changes for #6563

cc @longhorn/dev-ui

  1. Add Snapshot Max Count and Snapshot Max Size to creating volume page. Default value is 0 for snapshotMaxCount and "0" for snapshotMaxSize. We have a webhook to update snapshotMaxCount to global setting value if snapshotMaxCount == 0.
Screenshot 2024-01-05 at 6 31 34 PM 2. Add `Update Snapshot Max Count` and `Update Snapshot Max Size` to volume action list. Screenshot 2024-01-05 at 6 32 02 PM
  1. Add Snapshot Max Count setting to snapshot setting block. Default value can be get from snapshot-max-count setting.
Screenshot 2024-01-05 at 6 33 03 PM
@github-actions github-actions bot added area/ui UI related like UI or CLI highlight Important feature/issue to highlight kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal labels Jan 3, 2024
@github-actions github-actions bot added this to the v1.6.0 milestone Jan 3, 2024
@innobead innobead removed the highlight Important feature/issue to highlight label Jan 3, 2024
@longhorn-io-github-bot
Copy link

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@yangchiu
Copy link
Member

@FrankYang0529

Tested on master-head (longhorn-ui f865934). I create a volume with snapshot max size = 2.2 Gi via UI, and tried to update it via UI, but the value displayed in the update dialog is 2.2000000001862645 Gi instead of 2.2 Gi:
snapshot_size_0

snapshot_size_1

Is it acceptable?

@scures
Copy link

scures commented Jan 22, 2024

@yangchiu longhorn/longhorn-ui#688 should fix that.
image

@FrankYang0529
Copy link
Contributor

It looks like size also has same issue. We can keep both having same behavior.

Screenshot 2024-01-22 at 4 15 44 PM

@scures
Copy link

scures commented Jan 22, 2024

I sent a commit for that modal too :)

@yangchiu
Copy link
Member

Verified passed on master-head (longhorn-ui 418c7d6) and v1.6.x-head (longhorn-ui 63e29e8) following the test plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui UI related like UI or CLI kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal
Projects
None yet
Development

No branches or pull requests

5 participants