[BACKPORT][v1.5.4][BUG] When disabling revision counter, salvaging a faulty volume not work as expected

[github-actions]

backport #7714

[longhorn-io-github-bot]

Pre Ready-For-Testing Checklist

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at: see base issue [BUG] When disabling revision counter, salvaging a faulty volume not work as expected #7714

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Does the PR include the explanation for the fix or the feature?

• Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
  The PR for the YAML change is at:
  The PR for the chart change is at:

• Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
  The PR is at

• Which areas/issues this PR might have potential impacts on?
  Area
  Issues

• If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
  The LEP PR is at

• If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
  The UI issue/PR is at

• If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
  The documentation issue/PR is at

• If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
  The automation skeleton PR is at
  The automation test case PR is at
  The issue of automation test case implementation is at (please create by the template)

• If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
  The engine automation PR is at

• If labeled: require/manual-test-plan Has the manual test plan been documented?
  The updated manual test plan is at

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at

[roger-ryao]

Verified on v1.5.x-head 20240131

• longhorn v1.5.x-head 716fa15
• longhorn-engine v1.5.x-head longhorn/longhorn-engine@7b24786

The test steps

Referencing the documentation node-disconnection and the enhancement related to revision counter disable support PR: 20200821-add-revision-counter-disable-support:

1. Enable auto-salvage + DisableRevisionCounter.

   1. Disable the Revision Counter via the Longhorn UI.
   2. Deploy a new storage class: longhorn-test with disableRevisionCounter set to true in the parameters.

   parameters:
     numberOfReplicas: "3"
     disableRevisionCounter: "true"
     staleReplicaTimeout: "2880"
     fromBackup: ""
     fsType: "ext4"
   

2. Deploy a PVC and POD using the pod_with_pvc.yaml example, replacing the storageClassName value with longhorn-test.

3. Create a StatefulSet using a new storage class named longhorn-test and write data.

4. Execute test case 3 under specific conditions.

Result Passed

1. After enabling auto-salvage + DisableRevisionCounter, create, attach, and detach other volumes to the recovered node. All volumes should function correctly.