Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Chart v1.6.0-rc2 is not synced between longhorn/longhorn and longhorn/charts #7743

Closed
FrankYang0529 opened this issue Jan 22, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@FrankYang0529
Copy link
Contributor

Describe the bug

In longhorn/longhorn v1.6.0-rc2: there is priorityclass.yaml and servicemonitor.yaml.

In longhorn/charts v1.6.x: these two files are not in it.

Expected behavior

Chart files should be synced between two folder.

Environment

  • Longhorn version: v1.6.0-rc2
@innobead
Copy link
Member

The issue is the newly added files were not included in the automatically merged PR for RC2 at longhorn/charts#139.

That has been fixed in the PR of the tool, which we use in our automatic release at https://github.com/longhorn/release

@innobead
Copy link
Member

@chriscchien Please help check whether the built-in priority class and service monitor will be created correctly in https://github.com/longhorn/charts/tree/v1.6.x. Thanks.

cc @longhorn/qa

@chriscchien
Copy link
Contributor

Verified pass on longhorn v1.6.x chart

Using helm fresh install longhorn v1.6.x, upgrade from v1.4.x to v1.6.x and upgrade from v1.5.x to v1.6.x, after install/upgrade complete , can see builtin priority class longhorn-critical and service monitor longhorn-prometheus-servicemonitor created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants