Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.4.5][TASK] Review why sessionAffinity: ClientIP is used in most services #7759

Closed
github-actions bot opened this issue Jan 23, 2024 · 2 comments
Assignees
Labels
area/chart Helm chart related area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/backport Backport request kind/task General task request to fulfill another primary request priority/0 Must be fixed in this release (managed by PO)
Milestone

Comments

@github-actions
Copy link

backport #7399

@github-actions github-actions bot added area/chart Helm chart related area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/backport Backport request kind/task General task request to fulfill another primary request priority/0 Must be fixed in this release (managed by PO) labels Jan 23, 2024
@github-actions github-actions bot added this to the v1.4.5 milestone Jan 23, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 24, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at: [IMPROVEMENT] Remove static sessionAffinity: ClientIP set in most services if not required #7399 (comment).

  • Is there a workaround for the issue? If so, where is it documented?
    It a user needs to unset sessionAffinity: ClientIP before the PR, they can make the same manual changes the PR does to deploy/longhorn.yaml or chart/templates. If the user is using a managed chart (e.g. with Rancher), they can make they changes to the deployed services themselves.

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at: Remove sessionAffinity ClientIP from services (backport #7748) #7766.
    The PR for the chart change is at: Remove sessionAffinity ClientIP from services (backport #7748) #7766.

  • Which areas/issues this PR might have potential impacts on?
    It is unclear why sessionAffinity: ClientIP was ever enabled and it does not appear to have any negative effects to disable it. However, there may be an unintended consequence (especially for some corner case deployment) that we do not expect.

@roger-ryao roger-ryao self-assigned this Feb 6, 2024
@roger-ryao
Copy link

Verified on v1.4.x-head 20240206

The test steps
#7399 (comment)

Result Passed

  1. Upgrade Longhorn from version v1.4.4 to v1.4.x-head using the manifest.
  2. Upgrade Longhorn from version v1.4.4 to v1.4.x-head using the Helm chart.

In v1.4.4, sessionAffinity: ClientIP was set for services:

kubectl -n longhorn-system get service -oyaml | grep -e "sessionAffinity: ClientIP"
    sessionAffinity: ClientIP
    sessionAffinity: ClientIP
    sessionAffinity: ClientIP
    sessionAffinity: ClientIP

After the upgrade to v1.4.x-head, they no longer exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart Helm chart related area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/backport Backport request kind/task General task request to fulfill another primary request priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Development

No branches or pull requests

3 participants