Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.5.4][IMPROVEMENT] Remove startup probe of CSI driver after liveness probe conn fix ready #7933

Closed
github-actions bot opened this issue Feb 15, 2024 · 3 comments
Assignees
Labels
area/csi CSI related like control/node driver, sidecars area/upstream Upstream related like tgt upstream library kind/backport Backport request kind/improvement Request for improvement of existing function
Milestone

Comments

@github-actions
Copy link

backport #7428

@github-actions github-actions bot added area/csi CSI related like control/node driver, sidecars area/upstream Upstream related like tgt upstream library kind/backport Backport request kind/improvement Request for improvement of existing function labels Feb 15, 2024
@github-actions github-actions bot added this to the v1.5.4 milestone Feb 15, 2024
@ejweber
Copy link
Contributor

ejweber commented Feb 15, 2024

I know it is late in the v1.5.4 cycle, but @PhanLe1010, @james-munson, and I discussed it and agree that it is better to get these changes merged before v1.5.4 releases. It is because no version of v1.5.x has gone out yet with the workaround fix I implemented. This final fix is safer and better.

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Feb 15, 2024

Pre Ready-For-Testing Checklist

@chriscchien chriscchien self-assigned this Feb 16, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn v1.5.x (longhorn-manager b2410e) with test steps

Change service longhorn-backend to port 5001 then delete any longhorn-csi-plug-xx pod, after pod recreated, container longhorn-csi-plugin and node-driver-registrar will keep in state CrashLoopBackOff, container longhorn-liveness-probe will keep in running state.
Change service longhorn-backend back to the original port, all 3 containers in pod longhorn-csi-plug-xx become in running state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi CSI related like control/node driver, sidecars area/upstream Upstream related like tgt upstream library kind/backport Backport request kind/improvement Request for improvement of existing function
Projects
None yet
Development

No branches or pull requests

3 participants