Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.6.1][IMPROVEMENT] Improve environment_check script for NFS protocol bug and the host system self diagnosis #7971

Closed
github-actions bot opened this issue Feb 20, 2024 · 4 comments
Assignees
Labels
area/environment-issue User-specific related issues, ex: network, DNS, host packages, etc. kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/knowledge-base Require adding knowledge base document
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Feb 20, 2024

backport #7931

This is just tracking the change to environment_check.sh, not the added Node Condition from that issue.

@github-actions github-actions bot added area/environment-issue User-specific related issues, ex: network, DNS, host packages, etc. kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/knowledge-base Require adding knowledge base document labels Feb 20, 2024
@github-actions github-actions bot added this to the v1.6.1 milestone Feb 20, 2024
@james-munson
Copy link
Contributor

Marking as ready for test.

@roger-ryao roger-ryao self-assigned this Mar 1, 2024
@roger-ryao
Copy link

Hi @james-munson:
After running environment_check.sh, I noticed two things that need improvement:

  1. The link https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported.md should be updated to https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported/.
  2. According to https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported/, the Ubuntu kernel version 6.5.0-21 is also known to have the issue, but this information is not reflected in the environment_check.sh output.
[INFO]  MountPropagation is enabled
[INFO]  Checking kernel release...
[WARN]  Node w2-standard-pc-q35-ich9-2009 has a kernel version 5.15.0-97-generic known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported.md
[INFO]  Checking iscsid...

Screenshot_20240301_160834

@james-munson
Copy link
Contributor

After discussion, we decided to leave the check range as it is, and not try to maintain an exhaustive list of kernels to warn about in this script.
The invalid reference to the KB page has already been fixed and backported in a separate PR.

@roger-ryao
Copy link

Verified on v1.6.x-head 20240311

Result Passed

The link https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported.md has be updated to https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported/.

> curl -sSfL https://raw.githubusercontent.com/longhorn/longhorn/v1.6.x/scripts/environment_check.sh | bash
[INFO]  Required dependencies 'kubectl jq mktemp sort printf' are installed.
[INFO]  All nodes have unique hostnames.
[INFO]  Waiting for longhorn-environment-check pods to become ready (0/3)...
[INFO]  All longhorn-environment-check pods are ready (3/3).
[INFO]  MountPropagation is enabled
[INFO]  Checking kernel release...
[WARN]  Node w2-standard-pc-q35-ich9-2009 has a kernel version 5.15.0-97-generic known to have a breakage that affects Longhorn.  See description and solution at https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported
[INFO]  Checking iscsid...
[ERROR] Neither iscsid.service nor iscsid.socket is running on w1-standard-pc-q35-ich9-2009
[ERROR] Neither iscsid.service nor iscsid.socket is running on c1-standard-pc-q35-ich9-2009
[ERROR] Neither iscsid.service nor iscsid.socket is running on w2-standard-pc-q35-ich9-2009
[INFO]  Checking multipathd...
[INFO]  Checking packages...
[ERROR] nfs-common is not found in w1-standard-pc-q35-ich9-2009.
[ERROR] nfs-common is not found in c1-standard-pc-q35-ich9-2009.
[ERROR] nfs-common is not found in w2-standard-pc-q35-ich9-2009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environment-issue User-specific related issues, ex: network, DNS, host packages, etc. kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/knowledge-base Require adding knowledge base document
Projects
None yet
Development

No branches or pull requests

2 participants