Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.6.1][BUG] Use config map to update default-replica-count won't apply to default-replica-count.definition.default if the value equal to current default-replica-count.value #8134

Closed
github-actions bot opened this issue Mar 8, 2024 · 2 comments
Assignees
Labels
area/setting Global setting or volume setting kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/3 Function working but has a major issue w/ workaround
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Mar 8, 2024

backport #7755

@github-actions github-actions bot added area/setting Global setting or volume setting kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/3 Function working but has a major issue w/ workaround labels Mar 8, 2024
@github-actions github-actions bot added this to the v1.6.1 milestone Mar 8, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Mar 8, 2024

Pre Ready-For-Testing Checklist

@roger-ryao
Copy link

roger-ryao commented Mar 14, 2024

Verified on v1.6.1-rc1 20240314

The test steps
#7755 (comment)

Result Passed

  1. Deploy Longhorn(master-head, v1.6.1-rc1)

  2. Update default-replica-count to 4 by UI or by kubectl
    kubectl -n longhorn-system patch -p '{"value": "4"}' --type=merge lhs default-replica-count

  3. From API, the value: 4, definition.default: 3
    Screenshot_20240314_174836

  4. Apply below yaml to update default replica count to 4 by config map

    apiVersion: v1
    data:
      default-setting.yaml: |
        default-replica-count: 4
        priority-class: longhorn-critical
    kind: ConfigMap
    metadata:
      name: longhorn-default-setting
      namespace: longhorn-system
    
  5. Kubectl replied configmap/longhorn-default-setting configured, Can see both definition.default and value updated to 4

    > k apply -f update_default_replica.yaml
    configmap/longhorn-default-setting configured
    

    Screenshot_20240314_175053

  6. Apply below yaml to update default replica count to 5 by config map

    apiVersion: v1
    data:
      default-setting.yaml: |
        default-replica-count: 5
        priority-class: longhorn-critical
    kind: ConfigMap
    metadata:
      name: longhorn-default-setting
      namespace: longhorn-system
    
  7. Can see both definition.default and value updated to 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setting Global setting or volume setting kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage severity/3 Function working but has a major issue w/ workaround
Projects
None yet
Development

No branches or pull requests

3 participants