Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.6.2][IMPROVEMENT] Prevent unnecessary updates of instanceManager status #8421

Closed
github-actions bot opened this issue Apr 23, 2024 · 2 comments
Closed

[BACKPORT][v1.6.2][IMPROVEMENT] Prevent unnecessary updates of instanceManager status #8421

github-actions bot opened this issue Apr 23, 2024 · 2 comments
Assignees
@yangchiu @derekbit
Labels
component/longhorn-manager Longhorn manager (control plane) kind/backport Backport request kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone
v1.6.2

Comments

@github-actions
Copy link

backport #8420
@github-actions github-actions bot added kind/backport Backport request kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated labels Apr 23, 2024
@github-actions github-actions bot added this to the v1.6.2 milestone Apr 23, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 28, 2024 •
edited by derekbit

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Run e2e test to check the fix doesn't introduce any side effects.

  • Does the PR include the explanation for the fix or the feature?

#8420 (comment)

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2760

  • Which areas/issues this PR might have potential impacts on?
    Area: instance manager update
    Issues

@yangchiu
Copy link
Member

yangchiu commented May 5, 2024

Verified passed on v1.6.x-head (longhorn-manager c32b3a9c). Daily regression didn't find any issue.
amd64: 355 pass, 0 fail
arm64: 354 pass, 0 fail

@yangchiu yangchiu closed this as completed May 5, 2024
@yangchiu yangchiu self-assigned this May 5, 2024
@derekbit derekbit added the component/longhorn-manager Longhorn manager (control plane) label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangchiu yangchiu

@derekbit derekbit

Labels
component/longhorn-manager Longhorn manager (control plane) kind/backport Backport request kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Milestone
v1.6.2
Development

No branches or pull requests
3 participants
@yangchiu @derekbit @longhorn-io-github-bot