Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Rector Class #586

Open
mjamilasfihani opened this issue Jan 9, 2023 · 1 comment · May be fixed by #587
Open

Deprecated Rector Class #586

mjamilasfihani opened this issue Jan 9, 2023 · 1 comment · May be fixed by #587

Comments

@mjamilasfihani
Copy link
Contributor

myth-auth/rector.php

Line 32 in da35227

use Rector\Php74\Rector\Property\TypedPropertyRector;

from the comment :

/**
 * @deprecated Moving doc types to type declarations is dangerous. Use specific strict types instead.
 * This rule will be split info many small ones.
 */

and I've check the devkit that it should change to Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector.

here is the commit history codeigniter4/devkit@cf4df09
@mjamilasfihani
Copy link
Contributor Author

so many changes in devkit, should I rework all of them to? I mean, sync with the latest

@mjamilasfihani mjamilasfihani linked a pull request Jan 9, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update development kit mjamilasfihani/myth-auth
1 participant
@mjamilasfihani