New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F1 bug: doesn't filter _value properly #167
Comments
Maybe use a split at first before checking the exact match? parts[parts.length - 1].split(" ").some(substring => [
'SQL_TABLE_NAME',
'_sql',
'_value',
'_name',
'_filters',
'_parameter_value',
'_rendered_value',
'_label',
'_link',
].includes(substring)); for this: https://github.com/looker-open-source/look-at-me-sideways/blob/master/rules/f1.js#L60 |
Yea, that regex is definitely suspect! Thanks for the clear example, I'll queue this up :) |
I have the same issue with fields dependent on parameters |
@erictt's PR should be published to v3.1.3 and v2.1.8 @mariana-s-fernandes - does Eric's fix address your comment too, or no? |
Thank you so much for the merging! |
My pleasure! I was a little strapped for time in the second half of Q1, so my apologies it took me so long. Had a few things to clean up & add along with the merge and it took me a while to get to it |
@fabio-looker this one is ok now! Thanks! |
For example,
This will trigger the F1 error.
I checked the regex here, and found the parts actually are:
Given the parts, the filter list won't work since
_value
is not identified as a single field.The text was updated successfully, but these errors were encountered: