-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUI v5 - What is the status? Open questions? Call for help! =) #401
Comments
Fantastic. This will also allow us to fix some stuff too. One huge thing I'm wondering is if we want to stick with RFF. https://react-hook-form.com/ has really taken off, while RFF has kind of stagnated. |
Great point - Let me spend some time with RHF and I'll follow up with my feedback on whether to pursue the v5 upgrade or deprecate. |
I'd also be open to using a different build system. Well, pretty much changing everything really... The JS/TS ecosystems move fast and if you stick to one thing too long, it gets boring. Except MUI, I still love MUI. ;-) |
@radicand For a new project, I just looked into react-hook-form and there isn't currently any good (imho) OSS alternative that integrates with MUI. After a brief search, I found this one: https://github.com/dohomi/react-hook-form-mui It isn't horrible, but it has some odd opinionated stuff like including validation for email. It is also not very well unit tested. So, being lazy, I'll just continue to use this project for now. =) |
It's good timing, I've been using RHF extensively since you recommended checking it out, and on the whole I like it a lot. The only trouble I've had is with the Autocomplete widget, but it was not too difficult to overcome using the Controller pattern for just that one component. Everything else works with the framework-recommended |
I still believe there is a need for a middleware with regards to MUI. First off, you've probably wrapped your input components, it would be nice to not have to do that for every project. MUI has a bunch of chrome elements that need to get added, like FormControl for Select elements. It is nice having something that generates the Data for you for Select/Checkbox. Finally... unit tests... But good to hear that you're happy. I'll consider doing a library in the future. I just tried to upgrade the MUI dependencies and while the library itself is passing tests, now tsdx is giving me weird issues with eslint and I also had to upgrade husky. What a mess... code rots. Grrr... |
Hi, as of July 1st MUI has launched their v5 beta: https://github.com/mui-org/material-ui/releases/tag/v5.0.0-beta.0 In their release they mention:
I believe they have no new breaking changes planned as of their v5 API beta release. Is there an ETA on when mui-rff plans to have a compatible version? I've tried upgrading to their 5v beta and mui-rff is the dependency still blocking us. |
Hey @adam-bates ! Thanks for this. It would be awesome to get some help here. It should be pretty easy to git clone mui-rff, edit the dependencies and then run the tests... if you can do that and let me know how that goes, I'd appreciate it! =) |
Hello! MUI v.5 has been released in a stable version 7 days ago and I'm wondering when |
When? LOL! As soon as I get some help around here. =) 32.7k downloads a month... and just a handful of helpers... |
Update: @sgarcialaguna is doing some great work here... I think we are close.... |
Great to hear that!! |
5.0.0 has just been published on npm. Thanks to the excellent work by @sgarcialaguna !!!!!!!!!!! |
Is your feature request related to a problem? Please describe.
This package is no longer compatible with the v5 alpha of MUI.
Describe the solution you'd like
Update to support MUI v5, preparing for the release.
Describe alternatives you've considered
N/A
Additional context
A few things have changed - specifically, pickers has been merged into Lab and there have been a few other changes. Keyboard*Picker is no longer an export. I'm working on creating a PR for testing against v5 to help with the migration, and will open it when I have something functional.
The text was updated successfully, but these errors were encountered: