Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad study (and lab) images #1038

Closed
mekline opened this issue Nov 16, 2022 · 1 comment · Fixed by #1063
Closed

Pad study (and lab) images #1038

mekline opened this issue Nov 16, 2022 · 1 comment · Fixed by #1063
Assignees

Comments

@mekline
Copy link
Contributor

mekline commented Nov 16, 2022

No description provided.

@mekline mekline changed the title Pad images? Pad study (and lab) images Nov 16, 2022
@mekline
Copy link
Contributor Author

mekline commented Nov 16, 2022

Currently, labs are asked to limit file sizes on upload, but we don't enforce the size at which they are displayed. This means that the study search page is 'ragged' because of differing heights, and some views render poorly or revert to the actual size: see this mobile view (https://lookit.mit.edu/studies/early-childhood-cognition-lab/):

Screen Shot 2022-11-16 at 12 55 16 PM

Solution: For all image types (study, lab banner, lab badge), define a standard aspect ratio. If provided image does not match this, pad with background color to fit it in the correct shape of box. Ensure that boxes are displaying at correct sizes on mobile, lab detail page, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants