Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Broken in Laravel 5.4.36 ? #24

Closed
eminos opened this issue Sep 3, 2017 · 3 comments
Closed

Broken in Laravel 5.4.36 ? #24

eminos opened this issue Sep 3, 2017 · 3 comments

Comments

@eminos
Copy link

eminos commented Sep 3, 2017

This package seems to be broken in Laravel 5.4.36. It worked fine with "5.4 from this spring".

Instead of updating the position column it creates a new item row altogether.

@lookitsatravis
Copy link
Owner

@eminos would you be able to provide an example which is not working as expected? A repo would be ideal since there are a number of dependencies to getting the package to work in your project. 5.4.36 does not (or rather, should not) have any changes which impact Listify according to the change log.

Hopefully it's just a configuration thing we can work through. I am not going to provide any patches to the existing version, because I am working on v2 which should be released soon. So, if there truly is a failure, I will make sure v2 address it.

Thanks!

@eminos
Copy link
Author

eminos commented Sep 4, 2017

@lookitsatravis I'm so sorry. It was totally a bug on my end. This issue should be closed.
Thanks for an awesome package!

@lookitsatravis
Copy link
Owner

No worries! Thanks for the kind words. Take care!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants