Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP transport (connector and Rack server) #1

Merged
merged 1 commit into from Jun 6, 2014

Conversation

tlrobinson
Copy link

No description provided.

Protobuf::Socketrpc::ErrorReason::IO_ERROR => 500
}

def initialize(options)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to:

def initialize(options={})
 # ...
end

Would allow running this a little more cleanly inside of a config.ru, .e.g:

require 'rubygems'
require 'rack'
require 'protobuf'
require 'protobuf/rpc/servers/http/server'

require 'my/rpc'

map '/' do
  run Protobuf::Rpc::Http::Server.new
end

@rtyler
Copy link

rtyler commented Jun 4, 2014

Largely looks good, but definitely needs some RSpecs added to validate that things will continue to work properly

@tlrobinson
Copy link
Author

Updated with suggested fixes and initial HTTP connector specs. Still needs server specs.

@tlrobinson
Copy link
Author

Updated with spec/lib/protobuf/rpc/servers/http/server_spec.rb

@rtyler
Copy link

rtyler commented Jun 6, 2014

I think there's more improvements that can go into this code, but let's merge it and keep on truckin'

rtyler pushed a commit that referenced this pull request Jun 6, 2014
Add support for HTTP transport (connector and Rack server)
@rtyler rtyler merged commit a75c661 into master Jun 6, 2014
@rtyler rtyler deleted the wip/http branch June 6, 2014 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants