-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should indexing logic require actual Sweep events at the aggregator level? #39
Comments
For now, the consensus is just to have a single event with the msg.sender in it if one trade or more is executed. |
POC to get the function input parameters in java
|
Does it impact the indexing performance? @rob-looksrare |
Based on gut feeling it does not impact the performance in a significant way, should be one extra call to rpc provider (did not do any tests regarding performance). |
Hmmm, let's stick to the current specs where there is one event from the aggregator then. 🤔 |
Alternatives could be to use call traces or to use other marketplace events (e.g., Seaport, LR, Sudo) and build a logic using these sources of on-chain data.
The text was updated successfully, but these errors were encountered: