-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider an adaptive algorithm by default #45
Comments
Hi. It's an interesting suggestion. I tried to implement it, but I encounter issues with escaping parameters ( If you have an idea for a quick solution that doesn't require rewriting large part of the script, please share. |
I finally managed to work on it. |
Awesome! Will try it out the next time :) |
I have reverted this change since it decreased performance of |
That's a bummer. Thanks for investigating! |
I really like
loomchild/volume-backup
because it just gets the job done. The only thing I usually stumble accross is the bzip2 default. In my cases, it just eats lots of CPU time without any real benefit. If I do not backup to a file, but copy a volume to another host (on the same 1GBit network), I usually look athtop
asking myself why I did not pass-c none
.I wondered if there is any adaptive compression algorithm around which automagically knows whether it should compress
--fast
or--best
in order to provide maximum throughput. And it seems that Zstandard actually implemented this: facebook/zstd#75As @loomchild mentioned in other issues, it's unlikely something other than bzip2 will be the default due to backwards compatibility. If you ever consider to change it, Zstandard with
--adapt
might actually be a good choice.For the time being, it might be a nice feature to pass the
--adapt
argument tozstd
, if possible. (Notice: I didn't do any tests; I just assume--adapt
works as nice as described).The text was updated successfully, but these errors were encountered: