Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fr - Lesson 4 - update fr/index.json #150

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

antododo
Copy link
Contributor

@antododo antododo commented Mar 2, 2018

To complete PR #133

  • I did these translations myself and own copyright for them
  • I didn't use a machine to do these translations
  • I assign all copyright to Loom Network for these translations

@antododo antododo mentioned this pull request Mar 2, 2018
3 tasks
Copy link
Collaborator

@enlight enlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

I do have one question though, why are there spaces in front of punctuation symbols? For example, you wrote Montrez votre armée de zombie à vos amis ! instead of Montrez votre armée de zombie à vos amis!.

@enlight enlight merged commit d7149f6 into CryptozombiesHQ:master Mar 3, 2018
@antododo
Copy link
Contributor Author

antododo commented Mar 3, 2018

It's a typographic rule in French to have a space before those punctuation symbols: ; ? ! : « » Theoretically, it should even be a non-breaking space. In French Canadian, the space is not mandatory and even in France a lot of people forget the space (because of English! 😉 ). It's hard to respect those rules writing both in French and English! For example, we also don't use uppercase for day and month: lundi, janvier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants