Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub changes from tendermint repository #793

Closed
traceCall opened this issue Mar 1, 2019 · 1 comment
Closed

Pubsub changes from tendermint repository #793

traceCall opened this issue Mar 1, 2019 · 1 comment

Comments

@traceCall
Copy link

bucky [5:44 AM]
Hi guys. We just tagged v0.31.0-dev0 and would appreciate some feedback. There’s one more major PR to go for v0.31 (tendermint/tendermint#3269). The big change in this version is to the pubsub internals - we no longer block on publishing events. This means clients may miss events if they’re not fast enough to receive them. The goal was to address issues #951, #1880, and #2826 (see the milestone https://github.com/tendermint/tendermint/milestone/19). Would be super valuable if folks could test it out to see if it somehow breaks their work flows, and to see if #3269 will be acceptable (imposing limits on number of subscribers and number of subscriptions per subscriber).

We’re probably going to need to do a serious rethink of the RPC at some point, and would be valuable to gather feedback. Basically we need to better differentiate endpoints that can be exposed to the public from those that are more for development, debugging, or administrative control. I’ve opened tendermint/tendermint#3367 to start tracking this and solicit feedback, so if you have thoughts, please include them there!

@enlight
Copy link
Contributor

enlight commented Oct 7, 2019

Probably too complicated to backport this stuff, will have to wait until the next Tendermint upgrade #1279

@enlight enlight closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants