This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
add LoongArch64 support for grub #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetist
requested review from
a team,
yetist,
hudsonzuo,
Angie-JA-Dou,
wqfree,
sdlaqz and
tong2357
and removed request for
a team,
yetist,
hudsonzuo,
Angie-JA-Dou,
wqfree,
sdlaqz and
tong2357
|
这个有点长，我需要看3到4天时间，预定一个 review 坑位 |
yetist
reviewed
Jun 1, 2021
| @@ -0,0 +1,26 @@ | |||
| diff --git a/build-aux/config.guess b/build-aux/config.guess | |||
| @@ -98,4 +98,5 @@ bootstrap_post_import_hook () { | |||
|
|
|||
| bootstrap_epilogue () { | |||
| mv INSTALL.grub INSTALL | |||
| patch -p1 -i "grub-core/lib/gnulib-patches/loongarch.patch" | |||
hudsonzuo
reviewed
Jun 5, 2021
|
@loongarch64/dev-team 请大家有空review一下grub，谢谢。 |
zhuyaliang
reviewed
Jul 5, 2021
xen0n
suggested changes
Sep 28, 2021
grub-core/kern/loongarch64/cache.S
Outdated
| #include <grub/symbol.h> | ||
|
|
||
| FUNCTION (grub_arch_sync_caches) | ||
| jirl $zero,$ra,0 |
There was a problem hiding this comment.
新的推上游的工具链都支持 jr $ra，不用写原始指令了，读起来顺一点
| static void | ||
| write_jump (int regn, void **target) | ||
| { | ||
| grub_uint32_t andi=0x4c000000; |
There was a problem hiding this comment.
- 用
#define 0x4c000000不是jirl吗？为啥写andi？
util/grub-mkimagexx.c
Outdated
| @@ -1969,12 +2192,18 @@ make_reloc_section (Elf_Ehdr *e, struct grub_mkimage_layout *layout, | |||
| if ((grub_target_to_host32 (s->sh_type) == SHT_REL) || | |||
| (grub_target_to_host32 (s->sh_type) == SHT_RELA)) | |||
| { | |||
| Elf_Rel *r; | |||
| Elf_Rela *r; | |||
There was a problem hiding this comment.
这边是重构了以前已有的代码？建议拆提交。上游不会允许一整个大提交同时做这么多事情
xen0n
reviewed
Sep 28, 2021
xen0n
reviewed
Sep 28, 2021
xen0n
reviewed
Oct 6, 2021
util/grub-install.c
Outdated
| @@ -1133,6 +1139,9 @@ main (int argc, char *argv[]) | |||
| case GRUB_INSTALL_PLATFORM_RISCV64_EFI: | |||
| efi_file = "BOOTRISCV64.EFI"; | |||
| break; | |||
| case GRUB_INSTALL_PLATFORM_LOONGARCH64_EFI: | |||
| efi_file = "BOOTLOONGARCH64.EFI"; | |||
There was a problem hiding this comment.
目前无论 CLFS 或者 Loongnix 提供的可用系统镜像中，这个文件都叫 BOOTLOONGARCH.EFI，可能在 UEFI 上游标准正式添加 LA 支持之前，这边要改成和真机默认行为一样？
|
commit e8c9f07 这是之前传言了一阵子的删除旧固件兼容性的提交吗？ |
Signed-off-by: Yang Qiming <yangqiming@loongson.cn>
yetist
pushed a commit
that referenced
this pull request
Jul 4, 2023
Currently bootstrap complains in the following way when patching gnulib files: patching file argp-help.c Hunk #1 succeeded at 52 (offset 1 line). Hunk #2 succeeded at 1548 (offset 115 lines). patching file mbswidth.c patching file mbswidth.h Hunk #1 succeeded at 40 (offset -5 lines). Let's fix it by amending line numbers in the patch. Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com> Reviewed-by: Alec Brown <alec.r.brown@oracle.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.