switch to GitHub Actions #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This looks amazing! I'd love to switch to GA. |
|
It currently uses nightly, but can be switched. See this line |
|
Got it. Could we switch to Another thing I wanted to ask, if you could run all the examples in the CI. IMHO it will be a nice addition to tests, to make sure examples do no produce runtime errors. |
|
sure, but I'll have to change my live plot example to only run for a
limited time. Maybe like ~5s?
…On Mon, Aug 23, 2021 at 12:32 AM Alexey Suslov ***@***.***> wrote:
Got it. Could we switch to stable please? since we are not using any
nightly features.
Another thing I wanted to ask, if you could run all the examples in the
CI. IMHO it will be a nice addition to tests, to make sure examples do no
produce runtime errors.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5YNWVDSOCCCJYKB32KWV3T6H2RDANCNFSM5CSJFKDQ>
.
|
|
5s is fine 👍 |
|
This is working and good to merge! |
|
Thanks @TDHolmes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No worries if you want to stick with Travis for CI, but thought I'd throw it up to see what you thought. Since it's coming from a fork you won't see the CI running, but see this PR on my fork for what it'd look like for future PRs if you merged.