Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-version only without structopt dependency #36

Closed
dvtomas opened this issue Sep 21, 2021 · 12 comments
Closed

lib-version only without structopt dependency #36

dvtomas opened this issue Sep 21, 2021 · 12 comments

Comments

@dvtomas
Copy link

dvtomas commented Sep 21, 2021

I'm using textplots as a lightweight lib only. Would it be possible to either split it into two crates, or use features, to have a structopt and meval dependencies free build?

@dvtomas
Copy link
Author

dvtomas commented Oct 8, 2021

Hello, anybody has an opinion on this?

@dvtomas
Copy link
Author

dvtomas commented Oct 14, 2021

@TDHolmes
Copy link
Contributor

TDHolmes commented Jan 5, 2022

Makes sense to me. structopt and meval is only used in the binary CLI so I think it might be able to be moved to [dev-dependencies]. should be easy

@TDHolmes
Copy link
Contributor

TDHolmes commented Jan 5, 2022

ah sorry, no it can't, but yeah it could be split into a feature and the CLI bin could be set to require that feature.

@dvtomas
Copy link
Author

dvtomas commented Jan 5, 2022

There's a discussion on how to do that in the "useful links" mentioned above.

@dvtomas
Copy link
Author

dvtomas commented Jan 18, 2022

/cc @micouy

Any thoughts on this yet? IMHO it would be the best and easiest to just make the CLI another example. I'm willing to do a PR if you agree.

@dvtomas
Copy link
Author

dvtomas commented Feb 10, 2022

??

@TDHolmes
Copy link
Contributor

TDHolmes commented Jul 2, 2022

I agree, I just hit this myself causing a duplicate dependency of a different version when I'm just using it as a library. I lean slightly towards the optional dependency or separate crate fix myself though.

@ttytm
Copy link

ttytm commented Oct 1, 2022

yep, would be great to have those options. Unfortunately, the crate becomes unusable in some cases. Allowing those things to be optionally enabled as features or as separate dependency would solve the issue.

@adri326
Copy link

adri326 commented Jun 10, 2023

meval seems to be unmaintained, and it depends on nom = ^1.0.0, which will become rejected in a future version of rust (rust-lang/rust#79813). The possible fixes for this upcoming deprecation are:

@dvtomas
Copy link
Author

dvtomas commented Jun 11, 2023

I think this should go into another issue.

Anyway, If looking for an alternative, I've had a good experience with evalexpr

@loony-bean
Copy link
Owner

Fixed in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants