Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crown Gear, objects not cut out #22

Closed
4styler opened this issue Aug 28, 2018 · 4 comments
Closed

Crown Gear, objects not cut out #22

4styler opened this issue Aug 28, 2018 · 4 comments

Comments

@4styler
Copy link

4styler commented Aug 28, 2018

Hello Guys,
i have tried your Mod (really great work :)) and i think i have found an error.
When i build a Crown gear than the "negative teeths" are not cut out.
(Die Negativzähne wurden aus dem Zahnkranz nicht ausgeschnitten)

When i change line 329 to:
if not fp.construct:
it is working.
Can you please check it?

It was the first and is the only Mod on my newly installed FreeCAD 0.17 13528

Kind regards
4styler

@looooo
Copy link
Owner

looooo commented Jan 4, 2019

The cutting operation takes quite some time, so there is a construct property. You can simple set this property to false to get the cutted object.

@bevinhex
Copy link
Contributor

bevinhex commented Nov 8, 2019

I suppose you already thought about increasing python performance overall as well, great job.

@looooo
Copy link
Owner

looooo commented Nov 8, 2019

the time used for the cut-operation is not limited by python but opencascade.

@bevinhex
Copy link
Contributor

Just a thought, I wonder if it is possible to make FreeCAD processes async, so that user can keep doing their stuff, result can show up later without freezing the interface, with that, even though the operation takes time, as long as it is indicating doing something, and showing gradually, users won't mind

@looooo looooo closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants