Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If "attachment" property exists, the request fails at line 557 of rest-builder #126

Closed
br-kwon opened this issue Sep 10, 2018 · 4 comments
Closed
Assignees

Comments

@br-kwon
Copy link
Contributor

br-kwon commented Sep 10, 2018

https://github.com/strongloop/loopback-connector-rest/blob/63bc8b7dd57ea9ac1e08cbee9b76f9676b3b8446/lib/rest-builder.js#L557

What is the variable 'r' supposed to be in this case? It is undefined at this point and is defined later as the invocation of this._request()

@virkt25
Copy link
Contributor

virkt25 commented Sep 11, 2018

r can be seen here: https://github.com/strongloop/loopback-connector-rest/blob/63bc8b7dd57ea9ac1e08cbee9b76f9676b3b8446/lib/rest-builder.js#L563

I think maybe it was supposed to be declared before we try using it. Would you like to submit a PR to address this issue?

@br-kwon
Copy link
Contributor Author

br-kwon commented Sep 11, 2018

Thanks @virkt25 I've submitted a pull request

@virkt25
Copy link
Contributor

virkt25 commented Sep 13, 2018

Thanks for the contribution @br-kwon! 🎉 💯 You change was landed and released in version 3.3.0. Is this issue good to close?

@br-kwon
Copy link
Contributor Author

br-kwon commented Sep 13, 2018

Great! yes you can close. thanks

@virkt25 virkt25 closed this as completed Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants