Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Custom Search widget to new site #31

Closed
crandmck opened this issue Jul 12, 2016 · 6 comments
Closed

Add Google Custom Search widget to new site #31

crandmck opened this issue Jul 12, 2016 · 6 comments

Comments

@crandmck
Copy link
Contributor

Create and add something similar to https://docs.strongloop.com/display/APIC/Search+LoopBack+docs to the new doc site.

@doublemarked
Copy link
Contributor

doublemarked commented Sep 7, 2016

IMHO search is essential as the hierarchy of the docs is not always intuitive. Currently the search box isn't working - assuming it's known and related to this Issue.

@crandmck
Copy link
Contributor Author

crandmck commented Sep 7, 2016

Yes @doublemarked it's known, and I agree it is absolutely essential. I'm going to try to fix this today if I can.

@crandmck crandmck mentioned this issue Sep 7, 2016
12 tasks
@crandmck
Copy link
Contributor Author

crandmck commented Sep 7, 2016

OK, 6deb328 added an initial implementation using Google Custom search. I wanted to customize the CSS, and the only way I could figure out how to do that was to use the older version of GCS. It seems to work OK, but I think we can still improve the look. Help with CSS is appreciated.

Also, I don't like that every time you load a page, it displays "Loading" before displaying the search box...and sometimes doesn't load quickly. The search results also look a bit wonky. But at least it's functional now.

It's supposed to have autocomplete, but I haven't seen it working.. so not sure what's going on with that.

@crandmck
Copy link
Contributor Author

crandmck commented Sep 8, 2016

I've marked this as "done" in #39 checklist, because it is functional. However, there is room for cosmetic improvement so I'm going to leave this issue open for the time being. Anyone with CSS-fu is welcome to make it look better. See https://github.com/strongloop/loopback.io/blob/gh-pages/_includes/topnav.html and https://github.com/strongloop/loopback.io/blob/gh-pages/css/gcs.css for a start.

@crandmck
Copy link
Contributor Author

On second thought, I'll go ahead and close this. We'll just open separate issues for cosmetic or other improvements to the search feature.

@doublemarked
Copy link
Contributor

Yea sure - functional and ugly is still functional :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants