Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comment for negotiateContentProducer #46

Closed
charlie-s opened this issue Feb 28, 2017 · 2 comments
Closed

Incorrect comment for negotiateContentProducer #46

charlie-s opened this issue Feb 28, 2017 · 2 comments
Labels
bug help wanted

Comments

@charlie-s
Copy link
Contributor

charlie-s commented Feb 28, 2017 •
edited

Description of feature (or steps to reproduce if bug)

negotiateContentProducer in lib/content-negotiation.js has its arguments in the incorrect order. It lists them in the comments as req, options, logWarning but in the signature as req, logWarning, options.
@charlie-s charlie-s mentioned this issue Feb 28, 2017
Open
@bajtos
Copy link
Member

bajtos commented Mar 13, 2017

@charlie-s thank you for reporting the problem. I think this is a great opportunity for new contributors to send their first pull request. Would you like to do that yourself?

@bajtos bajtos changed the title negotiateContentProducer Incorrect comment for negotiateContentProducer Mar 13, 2017
@charlie-s charlie-s mentioned this issue Mar 13, 2017
Merged
2 tasks
@charlie-s
Copy link
Contributor Author

Thanks bajtos, issued PR #49.

@bajtos bajtos closed this as completed Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charlie-s @bajtos