Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximum bolus is ignored #33

Closed
scottleibrand opened this issue Jun 15, 2016 · 3 comments
Closed

Maximum bolus is ignored #33

scottleibrand opened this issue Jun 15, 2016 · 3 comments
Labels
bug

Comments

@scottleibrand
Copy link

I have maximum bolus in Loop set to 1U (and 6U on the pump itself) and was just able to do a 1.5U bolus from Loop.
@CrushingT1D
Copy link

I tested this by setting my max to 0.1u in app and giving myself a 0.2u bolus and it gave the bolus as well.

@loudnate loudnate added the bug label Jun 16, 2016
@loudnate
Copy link
Collaborator

Yep – maxBolus is never used... 😊 https://github.com/loudnate/Loop/blob/master/Loop/Managers/DoseMath.swift#L131

@amazaheri
Copy link

Related to this would be great to validate carb entry, yesterday Sam by mistake keyed 5523 gr vs 55 and Loop suggested 553 units.

loudnate added a commit that referenced this issue Sep 28, 2016
@loudnate
Fixing a crash when displaying the max bolus error
e264670 
Fixes #33
erikdi pushed a commit to erikdi/Loop that referenced this issue Feb 10, 2019
@loudnate
Merge pull request LoopKit#33 from loudnate/swift2.2
735bcac 
Xcode 7.3 / Swift 2.2 support
ps2 pushed a commit that referenced this issue Jan 18, 2020
@darinkrauss
Fix copy-frameworks script; missing quotes around environment variable (
5985ead 
#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@loudnate @scottleibrand @amazaheri @CrushingT1D