Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember filter settings between LOOT instances #427

Closed
Ortham opened this issue Apr 29, 2015 · 2 comments
Closed

Remember filter settings between LOOT instances #427

Ortham opened this issue Apr 29, 2015 · 2 comments
Milestone

Comments

@Ortham
Copy link
Member

Ortham commented Apr 29, 2015

This was a feature before v0.7, but it got removed in all the churn. It's been requested again here.

Rather than relying on localStorage like in v0.6, which would involve setting up a cache for CEF to use, it's probably easier to just pass the filter state to C++ when quitting, and store this information in settings.yaml.

@Ortham Ortham modified the milestone: v0.7.x May 20, 2015
@Ortham
Copy link
Member Author

Ortham commented May 25, 2015

Filter memory for the checkbox filters has been implemented in 1f227dd.

Memory could easily be implemented for the content filter, but the conflict filter would be trickier. I've avoided implementing memory for those two filters because I think it would be less helpful and indeed welcome. They're not filters I can see anyone wanting on by default. I'll seek some user feedback on this though.

@Ortham Ortham closed this as completed May 25, 2015
@Ortham
Copy link
Member Author

Ortham commented May 26, 2015

Reopening this as the message filters aren't being applied correctly on startup.

@Ortham Ortham reopened this May 26, 2015
@Ortham Ortham closed this as completed in c7d3d4b May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant